Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open-bordered or incomplete textarea-resize-icon? #350

Closed
ddudda174 opened this issue Jul 6, 2020 · 4 comments · Fixed by #353
Closed

Open-bordered or incomplete textarea-resize-icon? #350

ddudda174 opened this issue Jul 6, 2020 · 4 comments · Fixed by #353
Labels
bug Something isn't working

Comments

@ddudda174
Copy link

ddudda174 commented Jul 6, 2020 •
edited
Loading

It seems that the textarea-resize-icon does not fit the default viewBox="0 0 16 16", but has to be changed to viewBox="0 0 18 18" to make all borders appear. Do you plan to resize the icon to fit into the standard viewBox size like the other icons, or do we have to resize the viewBox manually?

image
@ddudda174 ddudda174 added the bug Something isn't working label Jul 6, 2020
@mdo
Copy link
Member

mdo commented Jul 6, 2020

Confirmed, dimensions are outta whack. Will fix for stable v1.

@ddudda174
Copy link
Author

ddudda174 commented Jul 6, 2020 •
edited
Loading

I also noticed a small gap in the cone icon.
→ moved to #355

Uniform boxes (box-arrow-icons) would probably be more harmonious.
→ moved to #356

Should these additional icon flaws be moved to a separate issue? → done

@mdo
Copy link
Member

mdo commented Jul 6, 2020

Should these additional icon flaws be moved to a separate issue?

Yes, please! One issue for the cone, one for the box arrows, please.

mdo added a commit that referenced this issue Jul 6, 2020
@mdo
Fixes #350: Resize textarea-resize to fit 16x16 viewbox
ff3c8c3
@mdo mdo mentioned this issue Jul 6, 2020
Merged
@ddudda174
Copy link
Author

Should these additional icon flaws be moved to a separate issue?

Yes, please! One issue for the cone, one for the box arrows, please.

done!

mdo added a commit that referenced this issue Jul 23, 2020
@mdo
Fixes #350: Resize textarea-resize to fit 16x16 viewbox
a5365a7
mdo added a commit that referenced this issue Jul 23, 2020
@mdo
Fixes #350: Resize textarea-resize to fit 16x16 viewbox
6354cab
mdo added a commit that referenced this issue Jul 23, 2020
@mdo
Fixes #350: Resize textarea-resize to fit 16x16 viewbox
ac9833e
@mdo mdo closed this as completed in #353 Jul 28, 2020
mdo added a commit that referenced this issue Jul 28, 2020
@mdo
Fixes #350: Resize textarea-resize to fit 16x16 viewbox
2e3b6df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.0.0 stable icons twbs/icons
2 participants
@mdo @ddudda174