Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor error in README #1571

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix minor error in README #1571

merged 1 commit into from
Mar 13, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jan 24, 2023 •
edited
Loading

SVG's aren't technically HTML, so I changed:

Modify the SVGs source HTML

to:

Modify the SVGs source code

@coliff
Fix minor error in README
1f94baa 
SVG's aren't technically HTML, so I changed:
> Modify the SVGs source HTML
to:
> Modify the SVGs source code
Alex-Toucan
Alex-Toucan reviewed Feb 10, 2023
View reviewed changes
Copy link

@Alex-Toucan Alex-Toucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the creator wants to be technically correct, then sure. Should be more specific on what language it is, however.

@shynekomaid
Copy link

shynekomaid commented Mar 9, 2023 •
edited
Loading

Maybe, need change to just Modify the source code of the SVGs?

@XhmikosR XhmikosR merged commit 0cac9c3 into twbs:main Mar 13, 2023
@coliff coliff deleted the patch-1 branch March 13, 2023 13:59
@XhmikosR XhmikosR added the docs Improvements or additions to documentation label Mar 13, 2023
@XhmikosR XhmikosR added build meta and removed docs Improvements or additions to documentation build labels Mar 31, 2023
This was referenced May 20, 2024
Open
Open
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 1, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 21, 2024
Open
Open
Open
Open
@b1ue0ceanRun b1ue0ceanRun mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
@b1ue0ceanRun b1ue0ceanRun mentioned this pull request Sep 27, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 28, 2024
Open
@b1ue0ceanRun b1ue0ceanRun mentioned this pull request Sep 28, 2024
Open
This was referenced Sep 29, 2024
Open
Open
Open
Open
Open
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 5, 2024
Open
@b1ue0ceanRun b1ue0ceanRun mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 25, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Nov 1, 2024
Open
@b1ue0ceanRun b1ue0ceanRun mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Toucan Alex-Toucan Alex-Toucan left review comments

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
meta
Projects
No open projects
Icons v1.10.4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coliff @shynekomaid @XhmikosR @Alex-Toucan