Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons #9

Closed
wants to merge 12 commits into from
Closed

Update icons #9

wants to merge 12 commits into from

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 9, 2019

  • Tons of new ones (187 total now)
  • Move from strokes to fills only for sanity and consistency, rip stroke customizations

- Tons of new ones (187 total now)
- Move from strokes to fills only for sanity and consistency, rip stroke customizations
This was referenced Aug 9, 2019
Merged
@XhmikosR
Copy link
Member

XhmikosR commented Aug 9, 2019

I just ran icons-prep, feel free to squash and merge @mdo when you are happy with it

@MartijnCuppens MartijnCuppens mentioned this pull request Aug 9, 2019
@MartijnCuppens
Copy link
Member

We can move the fill="currentColor" attribute to the <svg> itself, the property is inherited by default anyway.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 9, 2019

Yeah this was what I meant with manual optimization for some icons too :)

Similarly, when there is more than one path, it might be possible to do some manual opts there.

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Aug 9, 2019

I'll have a look at those manual optimizations.

Edit: I can't set up this project because of this symlink:

/Users/mdo/work/icons/icons

Probably #6 and #8 need to be merged first.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 9, 2019

I'll merge the other PRs tomorrow and rebase this. I still need access to the Netlify account to fix previews, though. Also, I'm not sure what our deployment plan will be.

We can use Netlify or we can maybe hook up actions and push to the gh-pages branch when we tag or every time.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 9, 2019

Forgot to mention, the Hugo watch fix I reported will probably ship on Monday. I'll update the version after that and we should now be able to do things much more freely like mount the icons folder etc.

@mdo
Copy link
Member Author

mdo commented Aug 13, 2019

SVG changes are in #12, a basic script for classnames is in #11, #13 has the updated SVGO config, and #10 has the updated docs layout and ported content from my PR in Bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants