Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things we may want to do below alignment/indentations #17

Closed
4 tasks
aspiwack opened this issue Jan 10, 2019 · 1 comment
Closed
4 tasks

Things we may want to do below alignment/indentations #17

aspiwack opened this issue Jan 10, 2019 · 1 comment

Comments

@aspiwack
Copy link
Member

This is a bit of a hodgepodge issue, lest I forget.

  • Splitting the {-# LANGUAGE … #-} pragmas with list of extension into pragmas with a single extension
  • Sorting {-# LANGUAGE … #-} pragmas
  • Sorting import
    • Sorting import lists?

The rational is that none of these have structure, it's only to minimize diffs. And let tools insert these without fear.

Possibly, but maybe not a good idea, we could also change C => D => t into (C, D) => t. Again, it's for tools (such as Dante) which can insert constraints, but would have a hard time being too precise about layout.

@mrkkrp
Copy link
Member

mrkkrp commented May 8, 2019

I'm going to close this one because:

  • There is another more-specific issue about language pragmas: Implement automatic sorting of language pragmas #20.
  • We already sort imports and import lists.
  • The change with constraints would lead to altering of AST and I think we'll try to avoid that at least because it makes self-checks problematic (verifying that AST of formatted code is the same as AST of original code).

@mrkkrp mrkkrp closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants