Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell_haddock compatibility with prebuilt_dependencies #52

Closed
Fuuzetsu opened this issue Dec 29, 2017 · 0 comments · Fixed by #234
Closed

haskell_haddock compatibility with prebuilt_dependencies #52

Fuuzetsu opened this issue Dec 29, 2017 · 0 comments · Fixed by #234
Labels
P3 minor: not priorized type: feature request

Comments

@Fuuzetsu
Copy link
Collaborator

We may want to support prebuilt_dependencies of packages in haskell_haddock. This involves:

  • finding out paths of prebuilt_dependencies
  • adding them to --read-interface

We may be able to get these paths from ghc-pkg. To feed these paths into haddock itself we may want to use run_shell and interpolate or generate a response file with all the args prepopulated (but still needs run_shell most likely). These things can be a bit more granular by abusing files: for every prebuilt dependency, run ghc-pkg and produce a file with the path needed. Then when invoking haddock use $(cat path_of_prebuilt_dep_FOO) $(cat path_of_prebuilt_dep_BAR). This allows us to only invoke ghc-pkg once per every prebuilt dependency across all rules rather than call ghc-pkg for every single prebuilt dep for every single dep in the package which would likely be rather slow.

Before anything, think about whether we actually want this as a feature. prebuilt_dependencies is somewhat of a hack to begin with and maybe we should be encouraging to package more things and use prebuilt_dependencies less rather than encouraging its use.

Created from #47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 minor: not priorized type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants