Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nix Mix #375

Closed
torhovland opened this issue Mar 20, 2023 · 2 comments · Fixed by #438
Closed

Fix Nix Mix #375

torhovland opened this issue Mar 20, 2023 · 2 comments · Fixed by #438

Comments

@torhovland
Copy link
Member

Describe the bug
The Nix build is currently reporting warnings like this:

trace: warning: crane cannot find name attribute in /nix/store/i70apg8wmqwaw1d20w56yr3hyjvr4f21-source/Cargo.toml, consider setting `pname = "...";` explicitly
trace: warning: crane cannot find version attribute in /nix/store/i70apg8wmqwaw1d20w56yr3hyjvr4f21-source/Cargo.toml, consider setting `version = "...";` explicitly

To Reproduce

nix build

Expected behavior

No warnings or errors.

Additional context

ipetkov/crane#237 (comment)

@Niols
Copy link
Member

Niols commented Mar 20, 2023

I don't know how things work in Nix wrt Cargo, but I would tend to blame the fact that pname is set but not version here and here. Since name is pname+version, that should lead to the two errors above.

@torhovland
Copy link
Member Author

See also this: ipetkov/crane#281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants