Improved yoyo documentation #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't clear from the documentation that I had to pass anything into the `yoyo` function. I had to go look at the yoyo example page to figure that out. Hopefully this change will make it clear to the next person.
|
Thanks! Good catch @iangilman! |
|
Hmm, oh! Looks like the docs are already update-to-date here: https://github.com/tweenjs/tween.js/blob/main/docs/user_guide.md#yoyo We need to sync github pages, rather than update github pages directly. Tracking issue: #645 |
|
Funny! Glad I could help highlight the sync issue, though that was unintended 😄 Thank you for cherry picking my commit so I could get credit. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear from the documentation that I had to pass anything into the
yoyofunction. I had to go look at the yoyo example page to figure that out. Hopefully this change will make it clear to the next person.