Minor fix(es) to Client's _make_request #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmon758
approved these changes
Dec 22, 2021
Harmon758
added
Bug
|
Good catches! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code in master has
on lines 189-190 in
client.py. Because the key in theincludesdictionary is actuallypollsinstead ofpoll, line 190 is never executed, and thus the poll dictionaries fetched using the Twitter get request are never converted to Poll objects. This affects code consistency because all of the dictionaries inincludes["tweets"],includes["users"],includes["media"], andincludes["places"]get transformed into Tweet, User, Media, and Place objects respectively.The other 2 fixes are trivial style fixes only (added line break so the line isn't too long, and removed spaces surrounding = for styling consistency).