New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timebox] Investigate FDW failed states #5083

Closed

Tracked by

Weiko opened this issue Apr 22, 2024 · 1 comment

Closed

Tracked by

[Timebox] Investigate FDW failed states #5083

Weiko opened this issue Apr 22, 2024 · 1 comment

Assignees

Member

Weiko commented Apr 22, 2024 •

edited

Loading

Check broken connection / wrong credentials
Check relations
Check app (show page, list, etc)

Weiko assigned ijreilly

Collaborator

ijreilly commented Apr 23, 2024

Investigation results

broken connexion / wrong credentials triggers server errors on list page if tables have been synchronized. (this should not be the case since we could already have broken connexion cases. An issue was created to handle that)
if the updated configuration connects to a db that has the same table names and table columns as the one synchronized, it keeps working

ijreilly closed this as completed

ijreilly mentioned this issue

[feat] Add updateRemoteServer endpoint #5148

Merged

ijreilly added a commit that referenced this issue


          [feat] Add updateRemoteServer endpoint (#5148)

76d4188

## Context
#4765 

Following investigations
([#5083](#5083)) we decided to
restrict updates of server from which zero tables have been synchronized
only

## How was it tested
Locally with /metadata
1. Updating a database that already has synchronized tables
<img width="1072" alt="Capture d’écran 2024-04-24 à 16 16 05"
src="https://github.com/twentyhq/twenty/assets/51697796/f9a84c34-2dcd-4f3c-b0bc-b710abae5021">

2. Updating a database that has no synchronized tables
<img width="843" alt="Capture d’écran 2024-04-24 à 16 17 28"
src="https://github.com/twentyhq/twenty/assets/51697796/f320fe03-a6bc-4724-bcd0-4e89d3ac31f5">
+ tested that the connection works well

ijreilly mentioned this issue

Remote Objects: master issue #3920

Closed

arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue


          [feat] Add updateRemoteServer endpoint (twentyhq#5148)

8d4369a

## Context
twentyhq#4765 

Following investigations
([twentyhq#5083](twentyhq#5083)) we decided to
restrict updates of server from which zero tables have been synchronized
only

## How was it tested
Locally with /metadata
1. Updating a database that already has synchronized tables
<img width="1072" alt="Capture d’écran 2024-04-24 à 16 16 05"
src="https://github.com/twentyhq/twenty/assets/51697796/f9a84c34-2dcd-4f3c-b0bc-b710abae5021">

2. Updating a database that has no synchronized tables
<img width="843" alt="Capture d’écran 2024-04-24 à 16 17 28"
src="https://github.com/twentyhq/twenty/assets/51697796/f320fe03-a6bc-4724-bcd0-4e89d3ac31f5">
+ tested that the connection works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment