Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Relation Icons Across Application #5660

Closed
Bonapara opened this issue May 29, 2024 · 9 comments · Fixed by #6504
Closed

Standardize Relation Icons Across Application #5660

Bonapara opened this issue May 29, 2024 · 9 comments · Fixed by #6504
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Current Behavior

We have an inconsistency in how we display relation icons across the app.

Fields list on an object detail page:

CleanShot 2024-05-29 at 17 57 14

New relation field icon:

CleanShot 2024-05-29 at 17 56 58

Customization of a new relation field:

image

Desired Behavior

We want to display this icon for one-to-many relations:

CleanShot 2024-05-29 at 17 57 37

And this icon for many-to-many relations.

CleanShot 2024-05-29 at 17 59 07

By default, we want to display the one-to-many icon everywhere.

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels May 29, 2024
@ijayhub
Copy link

ijayhub commented Jun 11, 2024

Please is this opened? If it is can I work on this.

@Bonapara
Copy link
Member Author

Sure @ijayhub, thanks for contributing!

@ijayhub
Copy link

ijayhub commented Jun 14, 2024

I am currently having an issue forking the repo
GitHubDesktop_cJQiTnnbli
please could anyone assist me?
Thanks

@Bonapara
Copy link
Member Author

@ijayhub maybe ask on our Discord: https://discord.com/invite/cx5n4Jzs57

@ijayhub
Copy link

ijayhub commented Jun 20, 2024

okay thanks

@Bonapara
Copy link
Member Author

Bonapara commented Jul 2, 2024

@ijayhub did it work?

@NitinPSingh
Copy link
Contributor

NitinPSingh commented Aug 1, 2024

hi @Bonapara , "has many" and "belongs to one" both are 1:N relationship ?
download (1)

and can you tell where N:N relationship is used in app?
download

@Bonapara
Copy link
Member Author

Bonapara commented Aug 1, 2024

@NitinPSingh, you're right. All relations are indeed 1:N for now. "Belongs to" is N:1, but there's no icon for this, so let's use 1:N as well!

@NitinPSingh
Copy link
Contributor

@Bonapara can you review the changes made in pr #6504

@twentyhq twentyhq deleted a comment from greptile-apps bot Aug 5, 2024
FelixMalfait added a commit that referenced this issue Aug 5, 2024
fix #5660 

- updated One to many [1:N] icon across app
- created many to one icon [N:1] , and added it in app


![download
(2)](https://github.com/user-attachments/assets/35ce05be-0f5f-4cd0-a1b7-7ab9062f74a0)
![download
(1)](https://github.com/user-attachments/assets/57316e49-c931-4ab5-ad4b-d04b241724c3)

---------

Co-authored-by: Félix Malfait <felix.malfait@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants