Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timebox] Migrate Link Field Type to the new Links field type #5909

Closed
Bonapara opened this issue Jun 17, 2024 · 3 comments · Fixed by #6332
Closed

[Timebox] Migrate Link Field Type to the new Links field type #5909

Bonapara opened this issue Jun 17, 2024 · 3 comments · Fixed by #6332
Assignees
@ijreilly
Labels
scope: backend Issues that are affecting the backend side only size: short type: chore

Comments

@Bonapara
Copy link
Member

Current behavior

We do offer two Link field types:
Link and Links

CleanShot 2024-06-17 at 16 33 40

Desired Behavior

We should migrate the Link field type to the new Links field type
@Bonapara Bonapara added scope: backend Issues that are affecting the backend side only size: short labels Jun 17, 2024
@greptile-apps Greptile Apps
Copy link
Contributor

greptile-apps bot commented Jun 17, 2024

  1. Update type guards in src/types/guards.ts to replace Link with Links.
  2. Modify input components in src/components/inputs to use Links instead of Link.
  3. Update hooks in src/hooks to handle Links field type.
  4. Change composite type definitions in src/types/composite.ts to use Links.
  5. Refactor any usage of Link in src/utils to Links.
  6. Ensure all references in src/schema are updated to Links.

References

@charlesBochet charlesBochet moved this from 🆕 New to 🔖 Planned in Product development ✅ Jun 18, 2024
@charlesBochet
Copy link
Member

We want to keep Links

@charlesBochet charlesBochet changed the title Migrate Link Field Type to the new Links field type [Timebox] Migrate Link Field Type to the new Links field type Jun 18, 2024
@charlesBochet
Copy link
Member

charlesBochet commented Jun 18, 2024 •
edited
Loading

Maybe a 0-21 command to make the migration manually?

@charlesBochet charlesBochet mentioned this issue Jul 11, 2024
Closed
@ijreilly ijreilly moved this from 🔖 Planned to 🏗 In progress in Product development ✅ Jul 11, 2024
@ijreilly ijreilly mentioned this issue Jul 12, 2024
Merged
ijreilly added a commit that referenced this issue Jul 12, 2024
@ijreilly
Forbid creation of link field type (#6237)
a442492 
This is the first step of Link field type deprecation
(#5909).
Forbid creation of link field type in product and api. Update to this
type is not a concern as we do not allow the update of field type.
@ijreilly ijreilly moved this from 🏗 In progress to 👀 In review in Product development ✅ Jul 19, 2024
@ijreilly ijreilly mentioned this issue Jul 19, 2024
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Product development ✅ Jul 23, 2024
@ijreilly ijreilly moved this from ✅ Done to 🏗 In progress in Product development ✅ Jul 24, 2024
@ijreilly ijreilly moved this from 🏗 In progress to ✅ Done in Product development ✅ Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ijreilly ijreilly

Labels
scope: backend Issues that are affecting the backend side only size: short type: chore
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate fields of deprecated type LINK to type LINKS twentyhq/twenty
3 participants
@charlesBochet @Bonapara @ijreilly