Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed onhover show from View Switcher Lock Design #4671

Closed
wants to merge 1 commit into from
Closed

fix: removed onhover show from View Switcher Lock Design #4671

wants to merge 1 commit into from

Conversation

HrushiYadav
Copy link

Fix #4653

@github-actions GitHub Actions
Copy link

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against fffc955

@Kanav-Arora
Copy link
Contributor

Hi @HrushiYadav
Thanks for contributing!

There should be a minor change. In the below screenshot you can see the pencil icon is also static.
Only the locked view should be static but the pencil icon should be visible only on hover.
Moreover please set the icon color to font.color.tertiary

Screenshot 2024-03-26 at 10 32 40 PM

Kanav-Arora
Kanav-Arora suggested changes Mar 26, 2024
View reviewed changes
...twenty-front/src/modules/ui/navigation/menu-item/internals/components/StyledMenuItemBase.tsx
pointer-events: none;
position: fixed;
pointer-events: auto;
position: static;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and the old code was better which had a hover block

@bosiraphael bosiraphael mentioned this pull request Mar 27, 2024
Merged
@HrushiYadav
Copy link
Author

@Kanav-Arora It will take time as I'm facing some issues with the setup

@FelixMalfait
Copy link
Member

Closing for now but feel free to re-open if problem isn't fixed by then! Thanks for your attempt to contribute 💙

@Kanav-Arora
Copy link
Contributor

@HrushiYadav
When you'll complete the setup feel free to reopen and continue working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kanav-Arora Kanav-Arora Kanav-Arora requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View Switcher Lock Design
3 participants
@HrushiYadav @Kanav-Arora @FelixMalfait