chore: extend root eslint config in twenty-server #4781
Conversation
thaisguigon
force-pushed
the
chore/mutualize-eslint-config
branch
from
a3c8448
to
89f73f0
Compare
thaisguigon
changed the title
thaisguigon
force-pushed
the
chore/use-root-eslint-config-in-twenty-server
branch
2 times, most recently
from
4e3a6ec
to
3e82703
Compare
thaisguigon
force-pushed
the
chore/use-root-eslint-config-in-twenty-server
branch
from
3e82703
to
0c0ea3b
Compare
| export function orderObjectProperties<T extends object>(data: T[]): T[]; | ||
|
|
||
| export function orderObjectProperties<T extends object>(data: T): T; | ||
|
|
||
| export function orderObjectProperties<T extends Array<any> | object>( | ||
| export const orderObjectProperties = <T extends object[] | object>( | ||
| data: T, | ||
| ): T { |
There was a problem hiding this comment.
@thaisguigon We should keep the use of function on the server side, only use arrow function is dropping multiple signature capability
| @@ -31,7 +31,7 @@ export const createApp = async ( | |||
| imports: [AppModule], | |||
| }); | |||
|
|
|||
| if (!!config.moduleBuilderHook) { | |||
| if (config.moduleBuilderHook) { | |||
There was a problem hiding this comment.
@thaisguigon Hmm careful with that, in this case it's not causing any issue, but when you're doing that in a react-native three it will cause error, it should not happen on react but can too:
This will cause issue (empty string is not allowed in the three):
<>
{myString && <></>}
</>
But this is not causing issue:
<>
{!!myString && <></>}
</>
There was a problem hiding this comment.
This custom rule (explicit-boolean-predicates-in-if) only applies to if statements, it won't flag conditions in JSX.
charlesBochet
assigned charlesBochet, thaisguigon and Weiko and unassigned magrinj, charlesBochet and Weiko
This reverts commit c80dab0.
|
To avoid the many conflicts, I've reopened a PR here #5101 and cherry picked the config change, will run the linter with the new folder structure and hopefully will merge today 🙏 |
Reopening @thaisguigon work from #4781 --------- Co-authored-by: Thaïs Guigon <guigon.thais@gmail.com>
Reopening @thaisguigon work from twentyhq#4781 --------- Co-authored-by: Thaïs Guigon <guigon.thais@gmail.com>
Following #4705: this is a proposal to extend the common root eslint config in twenty-server as well.