feat: simplify field preview logic in Settings #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Summary: feat: simplify field preview logic in Settings
- Simplified Field Preview Logic: Refactored
SettingsDataModelFieldPreview.tsxto useuseFieldPreviewValueinstead ofuseFieldPreview. - New Hooks and Utilities: Added
useFieldPreviewValue.ts,usePreviewRecord.ts,useRelationFieldPreviewValue.ts, and several utility functions to modularize and streamline field preview logic. - Removed Redundant Code: Deleted
useFieldPreview.tsandgetFieldDefaultPreviewValue.tsto reduce redundancy and improve maintainability. - Updated Tests: Renamed and updated test files to align with the new structure and ensure correct functionality of the refactored logic.
Notes:
- Potential Pitfalls: Ensure all field types are correctly handled by the new logic and that the changes integrate seamlessly with existing components.
- Opportunities for Reuse: The new utility functions and hooks can be reused across other modules to maintain consistency and reduce code duplication.
.../src/modules/settings/data-model/fields/preview/components/SettingsDataModelFieldPreview.tsx
Outdated
Show resolved
Hide resolved
...es/twenty-front/src/modules/settings/data-model/fields/preview/hooks/useFieldPreviewValue.ts
Show resolved
Hide resolved
.../src/modules/settings/data-model/fields/preview/hooks/useLabelIdentifierFieldPreviewValue.ts
Outdated
Show resolved
Hide resolved
...ront/src/modules/settings/data-model/fields/preview/utils/getMultiSelectFieldPreviewValue.ts
Outdated
Show resolved
Hide resolved
thaisguigon
force-pushed
the
feat/simplify-field-preview-logic-in-settings
branch
2 times, most recently
from
2759e7e
to
aa4c0c6
Compare
thaisguigon
changed the base branch from
main
to
refactor/reset-settings-field-default-value-on-field-type-change
Base automatically changed from
refactor/reset-settings-field-default-value-on-field-type-change
to
main
May 24, 2024 10:15
thaisguigon
force-pushed
the
feat/simplify-field-preview-logic-in-settings
branch
from
4b87609
to
2383d1a
Compare
thaisguigon
force-pushed
the
feat/simplify-field-preview-logic-in-settings
branch
from
2383d1a
to
e34651d
Compare
charlesBochet
approved these changes
May 24, 2024
Weiko
pushed a commit
that referenced
this pull request
May 31, 2024
Closes #5382 TODO: - [x] Test all field previews in app - [x] Fix tests - [x] Fix JSON preview
srp-pawar
added a commit
to synapsenet-arena/lead360
that referenced
this pull request
Jun 19, 2024
commit a4a63b0 Merge: bb2d74f d770e56 Author: Shubham Pawar <82868470+srp-pawar@users.noreply.github.com> Date: Thu May 30 15:38:46 2024 +0530 Merge branch 'main' of https://github.com/synapsenet-arena/lead360 commit d770e56 Author: Indrakant D <60315832+its-id@users.noreply.github.com> Date: Thu May 30 14:30:23 2024 +0530 fix: Poor contrast on SlashMenu (twentyhq#5342) fixes [twentyhq#5304](twentyhq#5304 (comment)) dark mode <img width="1425" alt="Screenshot 2024-05-09 at 1 59 56 AM" src="https://github.com/twentyhq/twenty/assets/60315832/70230f9e-607a-462a-8823-db8350d86bc4"> <br> <br> Light mode <img width="1448" alt="Screenshot 2024-05-09 at 2 01 06 AM" src="https://github.com/twentyhq/twenty/assets/60315832/523488a5-21de-4911-b11b-e28fba9adae6"> Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> commit 339aee6 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Thu May 30 10:45:46 2024 +0200 Run queries within queryRunner transaction sequentially (twentyhq#5668) Within a queryRunner transaction, it is important that migrations are run subsequently and not concurrently: otherwise if an error is thrown by one of the query, it will abort the transaction; any subsequent query running on the same queryRunner will cause the error _current transaction is aborted, commands ignored until end of transaction block_. Using an async function in a map as below does not guarantee that each query terminates before iterating over the next one, which can be an issue as described above, and which seems to cause [this sentry](https://twenty-v7.sentry.io/issues/5258406553/?environment=prod&project=4507072499810304&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=7d&stream_index=4). commit 9a23f9b Author: martmull <martmull@hotmail.fr> Date: Wed May 29 23:35:32 2024 +0200 4699 update the onboarding app placeholder (twentyhq#5616) ## Before  ## After  commit bcb582f Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Wed May 29 21:29:33 2024 +0200 Fixed button icon bug (twentyhq#5670) There was a bug with the isEmpty variable actually being a function from lodash instead of the result of `isFieldEmpty()`. commit 008813f Author: Aditya Pimpalkar <adipimpalkar@gmail.com> Date: Wed May 29 13:45:32 2024 +0100 fix: twenty-chrome-extension:"graphql:generate" (twentyhq#5649) fixes: twentyhq#5645 commit df2b76f Author: R894 <54629307+R894@users.noreply.github.com> Date: Wed May 29 14:34:29 2024 +0300 4848 - Update Checkbox component (twentyhq#4883) # Summary * Add hover state which defaults to **false** * Add disable state  closes twentyhq#4848 --------- Co-authored-by: Charles Bochet <charles@twenty.com> Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> commit ecff27f Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Wed May 29 12:45:29 2024 +0200 Improved hotkey scopes docs (twentyhq#5647) We have a lot of contributors that are not aware of our method for implementing hotkey listeners. I updated the documentation to provide clear examples so that users can refer to it and maintainers and reviewers can point to it when they see onKeyDown implementations. commit 5bb205b Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Tue May 28 18:01:05 2024 +0200 Fix update remote field metadata (twentyhq#5638) Closes twentyhq#5610. & update fetch-policy when fetching database on the remote databases show page to get freshest status. commit ebb1aa0 Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Tue May 28 15:54:57 2024 +0200 Add label to remote server (twentyhq#5637) Added label on remote server entity. Also added the possibility to update schema. <img width="688" alt="Capture d’écran 2024-05-28 à 15 36 31" src="https://github.com/twentyhq/twenty/assets/22936103/c9786122-8459-4876-833e-c9a1d7d27829"> commit ae6d5af Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Tue May 28 11:32:57 2024 +0200 Add missing stripe tables (twentyhq#5621) As title Still adding not working tables / columns commented so we know why these are not available. commit 443fb53 Author: Sage Bain <47053579+Shyesta@users.noreply.github.com> Date: Mon May 27 13:18:12 2024 -0700 Updated Past Events Font-Color to Primary for Visibility (twentyhq#5572) Issue: [twentyhq#5164](twentyhq#5164) Updated font-color of the title of past calendar events to be primary to improve visibility. Calendar event time font-color remains unchanged. Before:  After:  The year in month-year at the top of these screenshots also appears to be in tertiary font-color which can be adjusted too if that feels not visible enough. --------- Co-authored-by: ktang520 <ktang520@gmail.com> Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit ef64911 Author: Piyush Yadav <72244570+piyushyadav1617@users.noreply.github.com> Date: Mon May 27 21:36:34 2024 +0530 fix: Requests for new captcha token after a wrong password is entered. (twentyhq#5614) Fix issue where captcha did not reset after an incorrect password was entered and invalid token error was thrown, ensuring users receive a new captcha token on each attempt. before:  after: user can try again with a new captcha token and login smoothly without encountering the invalid token error. commit 9df3b40 Author: Félix Malfait <felix.malfait@gmail.com> Date: Mon May 27 16:08:00 2024 +0200 Fix search public api key (twentyhq#5609) It was the wrong API key since we changed the index commit 930237e Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 16:07:38 2024 +0200 Bump to version v0.12.1 (twentyhq#5608) commit f58c961 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 16:05:22 2024 +0200 Remove feature flag for Links field (twentyhq#5606) commit 8579714 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 15:16:50 2024 +0200 Bump version to v0.12.0 (twentyhq#5604) commit 1715aa8 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Mon May 27 15:16:21 2024 +0200 Remove hasCalendarEventStarted flaky test (twentyhq#5603) Remove hasCalendarEventStarted flaky test commit 2f52e0f Author: martmull <martmull@hotmail.fr> Date: Mon May 27 15:13:11 2024 +0200 5505 forgot password feature broken (twentyhq#5602) - add missing `excludedOperations` in `packages/twenty-server/src/engine/middlewares/graphql-hydrate-request-from-token.middleware.ts` - update generated graphql file - Add missing redirection to index after password update commit 113dfba Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 14:43:39 2024 +0200 Disable perf stories in chromatic (twentyhq#5597) Disabled chromatic for performance stories. commit 56ef8fc Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Mon May 27 14:42:45 2024 +0200 Fix missing avatar on People table (twentyhq#5601) As per title! commit 2c009af Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 14:02:38 2024 +0200 Added RecordFieldValueSelectorContext (twentyhq#5596) Added RecordFieldValueSelectorContext on mock container so that new record value using use-context-selector can work properly in fields module. commit 3051f3a Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 13:58:31 2024 +0200 Fixed new record value context selector sync in activity drawer (twentyhq#5594) Forgot to add `<RecordValueSetterEffect recordId={...} />` effect component for activity drawer during refactor. commit 8ee98e0 Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 13:40:53 2024 +0200 Fixed pending row edit mode (twentyhq#5592) This PR fixes creation on table. With the recent optimization refactor, we now use a custom event to trigger edit and soft focus mode on a table cell. There's a specific case when we create a pending row to allow creating a new record, where the custom event gets triggered before the cell exists, so it cannot listen and put itself in edit mode. The fix is passing down a new isPendingRow in the context, so the identifier cell on a pending row can put itself in edit mode during its first render. commit 2a1ea32 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 12:15:57 2024 +0200 Fix SnackBar visual (twentyhq#5569) cf https://discord.com/channels/1130383047699738754/1243478998810497054 commit bcb5cf7 Author: martmull <martmull@hotmail.fr> Date: Mon May 27 12:14:50 2024 +0200 Remove flash after create workspace (twentyhq#5589) ## Before https://github.com/twentyhq/twenty/assets/29927851/a6b4f580-4f01-4f5b-a023-f9fa0d9f9c28 ## After https://github.com/twentyhq/twenty/assets/29927851/2a1feb44-27ce-457d-86a2-eea46a313f98 commit 1f9c340 Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Mon May 27 11:50:19 2024 +0200 Fix record board broken position (twentyhq#5588) Position were not queries anymore while populating kanban board, breaking the drag and drop feature commit 446c556 Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 11:30:01 2024 +0200 Fixed entity chip navigate (twentyhq#5587) Fixed EntityChip, navigate had been removed during performance optimization, I put it back. commit 10abd7f Author: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com> Date: Mon May 27 16:38:37 2024 +0800 User & Metadata Loading (twentyhq#5347) ### Description User & Metadata Loading ### Refs twentyhq#4456 ### Demo https://github.com/twentyhq/twenty/assets/140154534/4c20fca6-feaf-45f6-ac50-6532d2ebf050 Fixes twentyhq#4456 --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit 74d7479 Author: Thomas des Francs <tdesfrancs@gmail.com> Date: Mon May 27 09:56:33 2024 +0200 Added Data Model Diagram to 0.12 changelog (twentyhq#5585) # Data Model Diagram Introduced an "Data Model Diagram" feature that allows users to visualize the relationships between different objects within the CRM.  --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit 9c046dc Author: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com> Date: Mon May 27 15:56:08 2024 +0800 Prefetch Skeleton Loading on Indexes and Shows (twentyhq#5545) ### Description Prefetch Skeleton Loading on Indexes and Shows ### Refs twentyhq#4458 ### Demo https://jam.dev/c/a1ad04e1-80b6-4b2a-b7df-373f52f4b169 https://jam.dev/c/c5038b97-2f18-4c29-8dee-18c09376e5ee Fixes: twentyhq#4458 --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit cfd83d6 Author: Abdullah <125115953+mabdullahabaid@users.noreply.github.com> Date: Sat May 25 19:09:25 2024 +0500 [UI] Remove theme constants from twenty-front and use the ones exported from twenty-ui. (twentyhq#5558) Some parts of the Frontend used theme constants exported from `modules/ui` while other parts used theme constants exported from `twenty-ui`. This PR centralizes theme constants by removing them from `modules/ui` completely. commit 9c325eb Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Sat May 25 12:29:20 2024 +0200 Fix opportunities board and CI (twentyhq#5573) RelationFieldDisplay was estabilishing a dependency on RecordTableContext which is not right as FieldDisplay can be loaded outside of RecordTable context I'm using an util directly but understand this is a bit heavier than before in term of performance. If we want to pre-compute this, we will need to be a bit smarter. Also the previous code based on fieldName was not right, we should check relationObjectMetadataItem instead commit 1c867d4 Author: brendanlaschke <brendan.laschke@googlemail.com> Date: Sat May 25 10:38:27 2024 +0200 Add Object Alternative view (twentyhq#5356) Current state: <img width="704" alt="Bildschirmfoto 2024-05-11 um 17 57 33" src="https://github.com/twentyhq/twenty/assets/48770548/c979f6fd-083e-40d3-8dbb-c572229e0da3"> I have some things im not really happy with right now: * If I have different connections it would be weird to display a one_one or many_one connection differently * The edges overlay always at one hand at the source/target (also being a problem with the 3 dots vs 1 dot) * I would have to do 4 versions of the 3 dot marker variant as an svg with exactly the same width as the edges wich is not as easy as it seems :) * The initial layout is not really great - I know dagre or elkjs could solve this but maybe there is a better solution ... If someone has a good idea for one or more of the problems im happy to integrate them ;) --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit 9080981 Author: martmull <martmull@hotmail.fr> Date: Sat May 25 10:36:59 2024 +0200 5509 remove flash on intermediate verify step when sign in with sso (twentyhq#5526) - remove flash on /verify - remove flash on signInUp - remove useless redirections and hooks - Remove DefaultHomePage component - Move redirections to /objects/companies in PageChangeEffect - add useShowAuthModal hooks and tests - add usePageChangeEffectNaviteLocation hooks and tests - fix refresh token expired produces blank screen commit f455ad4 Author: Thomas des Francs <tdesfrancs@gmail.com> Date: Sat May 25 10:29:30 2024 +0200 0.12 changelog (twentyhq#5560) Added the changelog items for: - Skeleton loading - Blocklist - Notification new design commit def1774 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Sat May 25 10:29:00 2024 +0200 [Fix] Object names should be camel cased (twentyhq#5571) as per title commit 936ac40 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Fri May 24 18:55:21 2024 +0200 Introduce a new feature flag for contact creation (twentyhq#5570) Introduce new feature flag `IS_CONTACT_CREATION_FOR_SENT_AND_RECEIVED_EMAILS_ENABLED` to allow contacts to be created for sent and received emails. commit a017847 Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Fri May 24 18:53:37 2024 +0200 Feat/performance-refactor-styled-component (twentyhq#5516) In this PR I'm optimizing a whole RecordTableCell in real conditions with a complex RelationFieldDisplay component : - Broke down getObjectRecordIdentifier into multiple utils - Precompute memoized function for getting chip data per field with useRecordChipDataGenerator() - Refactored RelationFieldDisplay - Use CSS modules where performance is needed instead of styled components - Create a CSS theme with global CSS variables to be used by CSS modules commit 3680647 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Fri May 24 18:33:44 2024 +0200 Fix sync token is no longer valid in calendar sync (twentyhq#5563) Fix sync token is no longer valid in calendar sync. https://developers.google.com/apps-script/add-ons/calendar/conferencing/sync-calendar-changes#implement_a_sync_trigger_function _Caution: Occasionally sync tokens are invalidated by the server, resulting in a Sync token is no longer valid error. When this happens, your code should conduct a full sync and replace any stored sync tokens you have._ commit 87465b1 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Fri May 24 18:27:54 2024 +0200 5507 modify the partial sync cron to work with the new statuses (twentyhq#5512) Closes twentyhq#5507 commit 3de5ed3 Author: Shashank Vishwakarma <shashank000s4@gmail.com> Date: Fri May 24 21:41:08 2024 +0530 Added: The support for CZK Currency (twentyhq#5561) Added the Czech Koruna currency support. - Added the CZK to the currency code. - Set the desired CZK icon to `TablerIcons` to use it within the `twenty-ui` fixes: twentyhq#5530   commit c7d61e1 Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 18:06:57 2024 +0200 feat: simplify field preview logic in Settings (twentyhq#5541) Closes twentyhq#5382 TODO: - [x] Test all field previews in app - [x] Fix tests - [x] Fix JSON preview commit 1ae7fbe Author: Peter W <techieshark@gmail.com> Date: Sat May 25 02:03:55 2024 +1000 docs: replace 'he' with 'they' (twentyhq#5562) Why: * allows for approximate doubling of the user base ;-) commit 736c79a Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 17:59:08 2024 +0200 fix: Links field fixes (twentyhq#5565) Related issue: twentyhq#3607 commit fa3443c Author: Félix Malfait <felix.malfait@gmail.com> Date: Fri May 24 17:58:37 2024 +0200 Improve autoload (twentyhq#5566) Set a 1000px margin to start fetching more records before we hit the bottom of the page, makes the scrolling experience a lot smoother :) commit 9ad3fb9 Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 17:58:12 2024 +0200 feat: move Snackbar to top of screen on mobile (twentyhq#5567) ... and change SnackBar blur to medium. @Bonapara Following twentyhq#5515 (comment) Related issue: twentyhq#5383 <img width="386" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/de2f0be4-9d9c-4013-bed2-774e0599ce49"> commit de9321d Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Fri May 24 16:52:05 2024 +0200 Fixed sync between record value context selector and record store (twentyhq#5517) This PR introduces many improvements over the new profiling story feature, with new tests and some refactor with main : - Added use-context-selector for getting value faster in display fields and created useRecordFieldValue() hook and RecordValueSetterEffect to synchronize states - Added performance test command in CI - Refactored ExpandableList drill-downs with FieldFocusContext - Refactored field button icon logic into getFieldButtonIcon util - Added RelationFieldDisplay perf story - Added RecordTableCell perf story - First split test of useField.. hook with useRelationFieldDisplay() - Fixed problem with set cell soft focus - Isolated logic between display / soft focus and edit mode in the related components to optimize performances for display mode. - Added warmupRound config for performance story decorator - Added variance in test reporting commit 82ec30c Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Fri May 24 12:26:42 2024 +0200 Expandable list remove anchor (twentyhq#5559) Deprecate anchorElement on ExpandableList to avoid props drilling. The anchorElement should be the ExpandableList container itself commit 7f7ea59 Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 12:15:17 2024 +0200 refactor: reset field default value on type change in Settings (twentyhq#5534) Related issue: twentyhq#5412 See twentyhq#5436 (comment) for context. commit 18fafbd Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Fri May 24 10:57:46 2024 +0200 Rename findAvailableTables endpoint (twentyhq#5557) As title commit 4bd0aaf Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Fri May 24 10:20:08 2024 +0200 [fix] Update remote table sync status in cache after schema update (twentyhq#5553) Upon schema update, sync status can change from synced to non_synced in case the update regards a table that was deleted. Let's update the sync status too to avoid displaying the table as still synchronized. https://github.com/twentyhq/twenty/assets/51697796/7ff2342b-ce9f-4179-9b76-940617cf1292 commit f9a3d5f Author: Aditya Pimpalkar <adipimpalkar@gmail.com> Date: Thu May 23 23:01:47 2024 +0100 chore: remove OAuth from chrome extension (twentyhq#5528) Since we can access the tokens directly from cookies of our front app, we don't require the OAuth process to fetch tokens anymore commit fede721 Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Thu May 23 22:36:50 2024 +0200 Add sorter for distant tables (twentyhq#5546) As title commit e00b19e Author: Jeet Desai <52026385+jeet1desai@users.noreply.github.com> Date: Thu May 23 21:56:08 2024 +0530 Change email tab placeholder illustration (twentyhq#5550) Fixes twentyhq#5502   commit fe5b558 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Thu May 23 17:00:24 2024 +0200 [FE] Update remote table schema + refactor Tables list (twentyhq#5548) Closes twentyhq#5062. Refactoring tables list to avoid rendering all toggles on each sync or schema update while using fresh data: - introducing id for RemoteTables in apollo cache - manually updating the cache for the record that was updated after a sync or schema update instead of fetching all tables again commit 0d6fe7b Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Thu May 23 14:59:34 2024 +0200 Handle relations separately for remotes (twentyhq#5538) Remote object id columns are not removed anymore when a remote object is unsynced. This is because we do not use relations anymore. We only created the id field. So the current behavior that was implemented for custom objects, to retrieve the fields to deleted, does not work. Since remote object relations are really different, I extracted the logic from `objectMetadataService`. It now handles only the relations for custom objects creation and deletion (this part should be extracted as well). I create a new remote table relation service that will: - fetch objects metadata linked to remotes (favorites, activityTargets...) - look for columns based on remote object name - delete the fields and columns commit 8019ba8 Author: Thaïs <guigon.thais@gmail.com> Date: Thu May 23 12:19:50 2024 +0200 feat: implement new SnackBar design (twentyhq#5515) Closes twentyhq#5383 ## Light theme <img width="905" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/ab0683c5-ded3-420c-ace6-684d38794a2d"> ## Dark theme <img width="903" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/4e43ca35-438d-4ba0-8388-1f061c6ccfb0"> commit 453525c Author: Jérémy M <jeremy.magrin@gmail.com> Date: Thu May 23 12:02:40 2024 +0200 fix: workspace health showing error for multi select (twentyhq#5547) Fix `workspace:health` command not working properly with `MULTI_SELECT` field metadata type. commit 7b1bea3 Author: Charles Bochet <charles@twenty.com> Date: Thu May 23 08:41:37 2024 +0200 Release patch v0.11.3 commit b8eef21 Author: Abdullah <125115953+mabdullahabaid@users.noreply.github.com> Date: Thu May 23 10:46:31 2024 +0500 [UI] Extract our ColorSample and Tag components from twenty-front to twenty-ui. (twentyhq#5543) Two more components extracted out of twenty-front: `ColorSample` and `Tag`. commit 6b1d4e0 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Thu May 23 07:43:09 2024 +0200 [Fix] Do not allow names with whitespaces (twentyhq#5542) As per title commit 04bf697 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 18:06:32 2024 +0200 feat: add feature flag to activate Links field creation (twentyhq#5535) Related issue: twentyhq#3607 commit 4e533bf Author: Weiko <corentin@twenty.com> Date: Wed May 22 17:14:33 2024 +0200 fix pgGraphqlQuery with concurent search path (twentyhq#5537) commit 5448512 Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Wed May 22 14:21:32 2024 +0200 Add quotes for table name (twentyhq#5533) As title commit 4b25181 Author: Ady Beraud <102751374+ady-beraud@users.noreply.github.com> Date: Wed May 22 15:02:54 2024 +0300 Fixed congratulations bot (twentyhq#5532) - Fixed bot - Added list of team members commit 40bd42e Author: Ady Beraud <102751374+ady-beraud@users.noreply.github.com> Date: Wed May 22 13:06:00 2024 +0300 Added Algolia Search (twentyhq#5524) -Added Algolia Search Box : <img width="707" alt="Screenshot 2024-05-22 at 10 05 13" src="https://github.com/twentyhq/twenty/assets/102751374/d26f9748-2a80-4690-88ca-16b078c52915"> -Added Algolia Search Bar: <img width="294" alt="Screenshot 2024-05-22 at 10 05 56" src="https://github.com/twentyhq/twenty/assets/102751374/ad503894-4ae1-41e4-bd4b-6241f7679142"> --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit 2e79bcc Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Wed May 22 11:20:44 2024 +0200 Sync stripe tables (twentyhq#5475) Stripe tables do not support `hasNextPage` and `totalCount`. This may be because of stripe wrapper do not properly support `COUNT` request. Waiting on pg_graphql answer [here](supabase/pg_graphql#519). This PR: - removes `totalCount` and `hasNextPage` form queries for remote objects. Even if it works for postgres, this may really be inefficient - adapt the `fetchMore` functions so it works despite `hasNextPage` missing - remove `totalCount` display for remotes - fix `orderBy` --------- Co-authored-by: Thomas Trompette <thomast@twenty.com> commit 35c1f97 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 11:18:16 2024 +0200 perf: use Nx cache for Chromatic script (twentyhq#5457) Makes sure the `twenty-front:chromatic:ci` task in the CI job `front-chromatic-deployment` reuses the cache of the Storybook built in the CI job `front-sb-build` instead of re-building Storybook so Chromatic is deployed faster in the CI. commit bb6df43 Author: Jérémy M <jeremy.magrin@gmail.com> Date: Wed May 22 11:11:05 2024 +0200 fix: twentyORM datasource configuration for ssl (twentyhq#5529) We need to specify ssl configuration for TwentyORM datasources when needed, otherwise connection will be broken. commit 474dfd7 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 10:55:24 2024 +0200 fix: fix Apollo client cache update error for Links field (twentyhq#5473) Fixes twentyhq#5437 commit d1cbd70 Author: Abdullah <125115953+mabdullahabaid@users.noreply.github.com> Date: Wed May 22 13:52:35 2024 +0500 Extract typography components from twenty-front to twenty-ui. (twentyhq#5466) Removed the following components from twenty-front and moved them to twenty-ui. - H1Title. - H2Title. - H3Title. Moving components in smaller chunks to ease the process of resolving conflicts. <img width="1255" alt="image" src="https://github.com/twentyhq/twenty/assets/125115953/a3953659-5dfd-4d03-a6de-50b064129d55"> Co-authored-by: Charles Bochet <charles@twenty.com> commit e2b48e2 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 10:42:08 2024 +0200 feat: edit link in Links field (twentyhq#5447) Closes twentyhq#5376 commit 47a6146 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 10:32:37 2024 +0200 feat: set primary link in Links field (twentyhq#5429) Closes twentyhq#5375 <img width="381" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/d87773df-c685-466b-ae35-a8349f79df48"> _____ ~~Note that I ugraded `@apollo/client` to v3.10.4 because current version is causing an error when trying to write the Links field in the cache in `updateRecordFromCache` (`TypeError: Cannot convert object to primitive value`). After upgrade, the error is gone but console still prints a warning (here the custom object name is `Listing` and the Links field name is `website`):~~ <img width="964" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/834b8909-e8dc-464a-8c5a-6b7e4c964a7f"> ~~It might be because the Links field seems to somehow have a `__typename` property in Apollo's cache, so Apollo considers it as a record and tries to match the object's cache with an id, but the Links field value has no id so it can't find it. We might want to find where this `__typename` is added and remove it from the Links object in the cache.~~ Edit: will fix this in another PR as upgrading `@apollo/client` + `apollo-upload-client` seems to break types and/or tests. Related issue: [twentyhq#5437](twentyhq#5437) commit 2386191 Author: martmull <martmull@hotmail.fr> Date: Wed May 22 09:55:29 2024 +0200 Fix missing logo at sign-in-up (twentyhq#5525) ### Before  ### After  commit 944b2b0 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 09:53:15 2024 +0200 fix: reset default value on field type switch in Settings/Data Model … (twentyhq#5436) …field form Closes twentyhq#5412 commit 4800388 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 09:39:21 2024 +0200 feat: remove a link from a Links field (twentyhq#5313) Closes twentyhq#5117 TO FIX in another PR: right now, the "Vertical Dots" LightIconButton inside the Dropdown menu sometimes needs to be clicked twice to open the nested dropdown, not sure why 🤔 Maybe an `event.preventDefault()` is needed somewhere? <img width="369" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/dd0c771a-c18d-4eb2-8ed6-b107f56711e9"> --------- Co-authored-by: Jérémy Magrin <jeremy.magrin@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit beaaf33 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Wed May 22 09:25:06 2024 +0200 5498 create a feature flag is gmail sync v2 enabled (twentyhq#5501) Closes twentyhq#5498 commit 5ad59b5 Author: Ady Beraud <102751374+ady-beraud@users.noreply.github.com> Date: Tue May 21 23:56:25 2024 +0300 Create congratulations bot (twentyhq#5404) - Created congratulations bot : <img width="939" alt="Screenshot 2024-05-14 at 12 47 13" src="https://github.com/twentyhq/twenty/assets/102751374/5138515f-fe4d-4c6d-9c7a-0240accbfca9"> - Modified OG image - Added png extension to OG image route To be noted: The bot will not work until the new API route is not deployed. Please check OG image with Cloudflare cache. --------- Co-authored-by: Ady Beraud <a.beraud96@gmail.com> commit 3deda2f Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Tue May 21 21:25:38 2024 +0200 Update foreign table to distant table schema (twentyhq#5508) Closes twentyhq#5069 back-end part And: - do not display schemaPendingUpdates status on remote server lists as this call will become too costly if there are dozens of servers - (refacto) create foreignTableService After this is merged we will be able to delete remoteTable's availableTables column commit 29c2780 Author: Charles Bochet <charles@twenty.com> Date: Tue May 21 20:36:25 2024 +0200 Fix vite.config duplicate cache configuration commit 36b467d Author: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com> Date: Wed May 22 02:24:08 2024 +0800 Fix storybook tests (twentyhq#5487) Fixes twentyhq#5486 --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit e47101e Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Tue May 21 13:31:39 2024 +0200 5483 modify messagechannel syncstatus (twentyhq#5484) - Closes twentyhq#5483 - Fix seeds - Add default value to syncSubStatus commit 66a23a8 Author: Jérémy M <jeremy.magrin@gmail.com> Date: Tue May 21 13:29:59 2024 +0200 fix: unwanted change moving back datetime to date (twentyhq#5499) Moving back datetime to date, due to an unwanted change. commit ec248f8 Author: martmull <martmull@hotmail.fr> Date: Tue May 21 12:08:51 2024 +0200 Remove dumb code placement (twentyhq#5494) Fix a bug introduced in [this PR](https://github.com/twentyhq/twenty/pull/5254/files) When a subscription is created, we need to create the subscription, twentyhq#5254 return if no subscription is created so the sub can never be created at all This PR fixes that commit 4fcdfbf Author: martmull <martmull@hotmail.fr> Date: Tue May 21 11:31:03 2024 +0200 Fix unhandled exception (twentyhq#5474) Solves exception.getStatus is not a function error logs in twenty-server Catch all errors in order to have no error log at all commit 0d16051 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Tue May 21 10:46:49 2024 +0200 [fix] Re-introduce beforeUpdateOneObject hook (twentyhq#5495) ... and disable name edition in object edition form. This feature will be introduced by twentyhq#5491 commit eb78be6 Author: Aditya Pimpalkar <adipimpalkar@gmail.com> Date: Tue May 21 09:39:43 2024 +0100 feat: replace iframe with chrome sidepanel (twentyhq#5197) fixes - twentyhq#5201 https://github.com/twentyhq/twenty/assets/13139771/871019c6-6456-46b4-95dd-07ffb33eb4fd --------- Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> commit 4907ae5 Author: Félix Malfait <felix.malfait@gmail.com> Date: Tue May 21 09:09:19 2024 +0200 Improve docs (twentyhq#5492) Fix twentyhq#4382 and remove useless pages to make docs more readable
srp-pawar
added a commit
to synapsenet-arena/lead360
that referenced
this pull request
Jun 19, 2024
commit a4a63b0 Merge: bb2d74f d770e56 Author: Shubham Pawar <82868470+srp-pawar@users.noreply.github.com> Date: Thu May 30 15:38:46 2024 +0530 Merge branch 'main' of https://github.com/synapsenet-arena/lead360 commit d770e56 Author: Indrakant D <60315832+its-id@users.noreply.github.com> Date: Thu May 30 14:30:23 2024 +0530 fix: Poor contrast on SlashMenu (twentyhq#5342) fixes [twentyhq#5304](twentyhq#5304 (comment)) dark mode <img width="1425" alt="Screenshot 2024-05-09 at 1 59 56 AM" src="https://github.com/twentyhq/twenty/assets/60315832/70230f9e-607a-462a-8823-db8350d86bc4"> <br> <br> Light mode <img width="1448" alt="Screenshot 2024-05-09 at 2 01 06 AM" src="https://github.com/twentyhq/twenty/assets/60315832/523488a5-21de-4911-b11b-e28fba9adae6"> Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> commit 339aee6 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Thu May 30 10:45:46 2024 +0200 Run queries within queryRunner transaction sequentially (twentyhq#5668) Within a queryRunner transaction, it is important that migrations are run subsequently and not concurrently: otherwise if an error is thrown by one of the query, it will abort the transaction; any subsequent query running on the same queryRunner will cause the error _current transaction is aborted, commands ignored until end of transaction block_. Using an async function in a map as below does not guarantee that each query terminates before iterating over the next one, which can be an issue as described above, and which seems to cause [this sentry](https://twenty-v7.sentry.io/issues/5258406553/?environment=prod&project=4507072499810304&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=7d&stream_index=4). commit 9a23f9b Author: martmull <martmull@hotmail.fr> Date: Wed May 29 23:35:32 2024 +0200 4699 update the onboarding app placeholder (twentyhq#5616) ## Before  ## After  commit bcb582f Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Wed May 29 21:29:33 2024 +0200 Fixed button icon bug (twentyhq#5670) There was a bug with the isEmpty variable actually being a function from lodash instead of the result of `isFieldEmpty()`. commit 008813f Author: Aditya Pimpalkar <adipimpalkar@gmail.com> Date: Wed May 29 13:45:32 2024 +0100 fix: twenty-chrome-extension:"graphql:generate" (twentyhq#5649) fixes: twentyhq#5645 commit df2b76f Author: R894 <54629307+R894@users.noreply.github.com> Date: Wed May 29 14:34:29 2024 +0300 4848 - Update Checkbox component (twentyhq#4883) # Summary * Add hover state which defaults to **false** * Add disable state  closes twentyhq#4848 --------- Co-authored-by: Charles Bochet <charles@twenty.com> Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> commit ecff27f Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Wed May 29 12:45:29 2024 +0200 Improved hotkey scopes docs (twentyhq#5647) We have a lot of contributors that are not aware of our method for implementing hotkey listeners. I updated the documentation to provide clear examples so that users can refer to it and maintainers and reviewers can point to it when they see onKeyDown implementations. commit 5bb205b Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Tue May 28 18:01:05 2024 +0200 Fix update remote field metadata (twentyhq#5638) Closes twentyhq#5610. & update fetch-policy when fetching database on the remote databases show page to get freshest status. commit ebb1aa0 Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Tue May 28 15:54:57 2024 +0200 Add label to remote server (twentyhq#5637) Added label on remote server entity. Also added the possibility to update schema. <img width="688" alt="Capture d’écran 2024-05-28 à 15 36 31" src="https://github.com/twentyhq/twenty/assets/22936103/c9786122-8459-4876-833e-c9a1d7d27829"> commit ae6d5af Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Tue May 28 11:32:57 2024 +0200 Add missing stripe tables (twentyhq#5621) As title Still adding not working tables / columns commented so we know why these are not available. commit 443fb53 Author: Sage Bain <47053579+Shyesta@users.noreply.github.com> Date: Mon May 27 13:18:12 2024 -0700 Updated Past Events Font-Color to Primary for Visibility (twentyhq#5572) Issue: [twentyhq#5164](twentyhq#5164) Updated font-color of the title of past calendar events to be primary to improve visibility. Calendar event time font-color remains unchanged. Before:  After:  The year in month-year at the top of these screenshots also appears to be in tertiary font-color which can be adjusted too if that feels not visible enough. --------- Co-authored-by: ktang520 <ktang520@gmail.com> Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit ef64911 Author: Piyush Yadav <72244570+piyushyadav1617@users.noreply.github.com> Date: Mon May 27 21:36:34 2024 +0530 fix: Requests for new captcha token after a wrong password is entered. (twentyhq#5614) Fix issue where captcha did not reset after an incorrect password was entered and invalid token error was thrown, ensuring users receive a new captcha token on each attempt. before:  after: user can try again with a new captcha token and login smoothly without encountering the invalid token error. commit 9df3b40 Author: Félix Malfait <felix.malfait@gmail.com> Date: Mon May 27 16:08:00 2024 +0200 Fix search public api key (twentyhq#5609) It was the wrong API key since we changed the index commit 930237e Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 16:07:38 2024 +0200 Bump to version v0.12.1 (twentyhq#5608) commit f58c961 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 16:05:22 2024 +0200 Remove feature flag for Links field (twentyhq#5606) commit 8579714 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 15:16:50 2024 +0200 Bump version to v0.12.0 (twentyhq#5604) commit 1715aa8 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Mon May 27 15:16:21 2024 +0200 Remove hasCalendarEventStarted flaky test (twentyhq#5603) Remove hasCalendarEventStarted flaky test commit 2f52e0f Author: martmull <martmull@hotmail.fr> Date: Mon May 27 15:13:11 2024 +0200 5505 forgot password feature broken (twentyhq#5602) - add missing `excludedOperations` in `packages/twenty-server/src/engine/middlewares/graphql-hydrate-request-from-token.middleware.ts` - update generated graphql file - Add missing redirection to index after password update commit 113dfba Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 14:43:39 2024 +0200 Disable perf stories in chromatic (twentyhq#5597) Disabled chromatic for performance stories. commit 56ef8fc Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Mon May 27 14:42:45 2024 +0200 Fix missing avatar on People table (twentyhq#5601) As per title! commit 2c009af Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 14:02:38 2024 +0200 Added RecordFieldValueSelectorContext (twentyhq#5596) Added RecordFieldValueSelectorContext on mock container so that new record value using use-context-selector can work properly in fields module. commit 3051f3a Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 13:58:31 2024 +0200 Fixed new record value context selector sync in activity drawer (twentyhq#5594) Forgot to add `<RecordValueSetterEffect recordId={...} />` effect component for activity drawer during refactor. commit 8ee98e0 Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 13:40:53 2024 +0200 Fixed pending row edit mode (twentyhq#5592) This PR fixes creation on table. With the recent optimization refactor, we now use a custom event to trigger edit and soft focus mode on a table cell. There's a specific case when we create a pending row to allow creating a new record, where the custom event gets triggered before the cell exists, so it cannot listen and put itself in edit mode. The fix is passing down a new isPendingRow in the context, so the identifier cell on a pending row can put itself in edit mode during its first render. commit 2a1ea32 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Mon May 27 12:15:57 2024 +0200 Fix SnackBar visual (twentyhq#5569) cf https://discord.com/channels/1130383047699738754/1243478998810497054 commit bcb5cf7 Author: martmull <martmull@hotmail.fr> Date: Mon May 27 12:14:50 2024 +0200 Remove flash after create workspace (twentyhq#5589) ## Before https://github.com/twentyhq/twenty/assets/29927851/a6b4f580-4f01-4f5b-a023-f9fa0d9f9c28 ## After https://github.com/twentyhq/twenty/assets/29927851/2a1feb44-27ce-457d-86a2-eea46a313f98 commit 1f9c340 Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Mon May 27 11:50:19 2024 +0200 Fix record board broken position (twentyhq#5588) Position were not queries anymore while populating kanban board, breaking the drag and drop feature commit 446c556 Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Mon May 27 11:30:01 2024 +0200 Fixed entity chip navigate (twentyhq#5587) Fixed EntityChip, navigate had been removed during performance optimization, I put it back. commit 10abd7f Author: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com> Date: Mon May 27 16:38:37 2024 +0800 User & Metadata Loading (twentyhq#5347) ### Description User & Metadata Loading ### Refs twentyhq#4456 ### Demo https://github.com/twentyhq/twenty/assets/140154534/4c20fca6-feaf-45f6-ac50-6532d2ebf050 Fixes twentyhq#4456 --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit 74d7479 Author: Thomas des Francs <tdesfrancs@gmail.com> Date: Mon May 27 09:56:33 2024 +0200 Added Data Model Diagram to 0.12 changelog (twentyhq#5585) # Data Model Diagram Introduced an "Data Model Diagram" feature that allows users to visualize the relationships between different objects within the CRM.  --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit 9c046dc Author: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com> Date: Mon May 27 15:56:08 2024 +0800 Prefetch Skeleton Loading on Indexes and Shows (twentyhq#5545) ### Description Prefetch Skeleton Loading on Indexes and Shows ### Refs twentyhq#4458 ### Demo https://jam.dev/c/a1ad04e1-80b6-4b2a-b7df-373f52f4b169 https://jam.dev/c/c5038b97-2f18-4c29-8dee-18c09376e5ee Fixes: twentyhq#4458 --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit cfd83d6 Author: Abdullah <125115953+mabdullahabaid@users.noreply.github.com> Date: Sat May 25 19:09:25 2024 +0500 [UI] Remove theme constants from twenty-front and use the ones exported from twenty-ui. (twentyhq#5558) Some parts of the Frontend used theme constants exported from `modules/ui` while other parts used theme constants exported from `twenty-ui`. This PR centralizes theme constants by removing them from `modules/ui` completely. commit 9c325eb Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Sat May 25 12:29:20 2024 +0200 Fix opportunities board and CI (twentyhq#5573) RelationFieldDisplay was estabilishing a dependency on RecordTableContext which is not right as FieldDisplay can be loaded outside of RecordTable context I'm using an util directly but understand this is a bit heavier than before in term of performance. If we want to pre-compute this, we will need to be a bit smarter. Also the previous code based on fieldName was not right, we should check relationObjectMetadataItem instead commit 1c867d4 Author: brendanlaschke <brendan.laschke@googlemail.com> Date: Sat May 25 10:38:27 2024 +0200 Add Object Alternative view (twentyhq#5356) Current state: <img width="704" alt="Bildschirmfoto 2024-05-11 um 17 57 33" src="https://github.com/twentyhq/twenty/assets/48770548/c979f6fd-083e-40d3-8dbb-c572229e0da3"> I have some things im not really happy with right now: * If I have different connections it would be weird to display a one_one or many_one connection differently * The edges overlay always at one hand at the source/target (also being a problem with the 3 dots vs 1 dot) * I would have to do 4 versions of the 3 dot marker variant as an svg with exactly the same width as the edges wich is not as easy as it seems :) * The initial layout is not really great - I know dagre or elkjs could solve this but maybe there is a better solution ... If someone has a good idea for one or more of the problems im happy to integrate them ;) --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit 9080981 Author: martmull <martmull@hotmail.fr> Date: Sat May 25 10:36:59 2024 +0200 5509 remove flash on intermediate verify step when sign in with sso (twentyhq#5526) - remove flash on /verify - remove flash on signInUp - remove useless redirections and hooks - Remove DefaultHomePage component - Move redirections to /objects/companies in PageChangeEffect - add useShowAuthModal hooks and tests - add usePageChangeEffectNaviteLocation hooks and tests - fix refresh token expired produces blank screen commit f455ad4 Author: Thomas des Francs <tdesfrancs@gmail.com> Date: Sat May 25 10:29:30 2024 +0200 0.12 changelog (twentyhq#5560) Added the changelog items for: - Skeleton loading - Blocklist - Notification new design commit def1774 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Sat May 25 10:29:00 2024 +0200 [Fix] Object names should be camel cased (twentyhq#5571) as per title commit 936ac40 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Fri May 24 18:55:21 2024 +0200 Introduce a new feature flag for contact creation (twentyhq#5570) Introduce new feature flag `IS_CONTACT_CREATION_FOR_SENT_AND_RECEIVED_EMAILS_ENABLED` to allow contacts to be created for sent and received emails. commit a017847 Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Fri May 24 18:53:37 2024 +0200 Feat/performance-refactor-styled-component (twentyhq#5516) In this PR I'm optimizing a whole RecordTableCell in real conditions with a complex RelationFieldDisplay component : - Broke down getObjectRecordIdentifier into multiple utils - Precompute memoized function for getting chip data per field with useRecordChipDataGenerator() - Refactored RelationFieldDisplay - Use CSS modules where performance is needed instead of styled components - Create a CSS theme with global CSS variables to be used by CSS modules commit 3680647 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Fri May 24 18:33:44 2024 +0200 Fix sync token is no longer valid in calendar sync (twentyhq#5563) Fix sync token is no longer valid in calendar sync. https://developers.google.com/apps-script/add-ons/calendar/conferencing/sync-calendar-changes#implement_a_sync_trigger_function _Caution: Occasionally sync tokens are invalidated by the server, resulting in a Sync token is no longer valid error. When this happens, your code should conduct a full sync and replace any stored sync tokens you have._ commit 87465b1 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Fri May 24 18:27:54 2024 +0200 5507 modify the partial sync cron to work with the new statuses (twentyhq#5512) Closes twentyhq#5507 commit 3de5ed3 Author: Shashank Vishwakarma <shashank000s4@gmail.com> Date: Fri May 24 21:41:08 2024 +0530 Added: The support for CZK Currency (twentyhq#5561) Added the Czech Koruna currency support. - Added the CZK to the currency code. - Set the desired CZK icon to `TablerIcons` to use it within the `twenty-ui` fixes: twentyhq#5530   commit c7d61e1 Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 18:06:57 2024 +0200 feat: simplify field preview logic in Settings (twentyhq#5541) Closes twentyhq#5382 TODO: - [x] Test all field previews in app - [x] Fix tests - [x] Fix JSON preview commit 1ae7fbe Author: Peter W <techieshark@gmail.com> Date: Sat May 25 02:03:55 2024 +1000 docs: replace 'he' with 'they' (twentyhq#5562) Why: * allows for approximate doubling of the user base ;-) commit 736c79a Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 17:59:08 2024 +0200 fix: Links field fixes (twentyhq#5565) Related issue: twentyhq#3607 commit fa3443c Author: Félix Malfait <felix.malfait@gmail.com> Date: Fri May 24 17:58:37 2024 +0200 Improve autoload (twentyhq#5566) Set a 1000px margin to start fetching more records before we hit the bottom of the page, makes the scrolling experience a lot smoother :) commit 9ad3fb9 Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 17:58:12 2024 +0200 feat: move Snackbar to top of screen on mobile (twentyhq#5567) ... and change SnackBar blur to medium. @Bonapara Following twentyhq#5515 (comment) Related issue: twentyhq#5383 <img width="386" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/de2f0be4-9d9c-4013-bed2-774e0599ce49"> commit de9321d Author: Lucas Bordeau <bordeau.lucas@gmail.com> Date: Fri May 24 16:52:05 2024 +0200 Fixed sync between record value context selector and record store (twentyhq#5517) This PR introduces many improvements over the new profiling story feature, with new tests and some refactor with main : - Added use-context-selector for getting value faster in display fields and created useRecordFieldValue() hook and RecordValueSetterEffect to synchronize states - Added performance test command in CI - Refactored ExpandableList drill-downs with FieldFocusContext - Refactored field button icon logic into getFieldButtonIcon util - Added RelationFieldDisplay perf story - Added RecordTableCell perf story - First split test of useField.. hook with useRelationFieldDisplay() - Fixed problem with set cell soft focus - Isolated logic between display / soft focus and edit mode in the related components to optimize performances for display mode. - Added warmupRound config for performance story decorator - Added variance in test reporting commit 82ec30c Author: Charles Bochet <charlesBochet@users.noreply.github.com> Date: Fri May 24 12:26:42 2024 +0200 Expandable list remove anchor (twentyhq#5559) Deprecate anchorElement on ExpandableList to avoid props drilling. The anchorElement should be the ExpandableList container itself commit 7f7ea59 Author: Thaïs <guigon.thais@gmail.com> Date: Fri May 24 12:15:17 2024 +0200 refactor: reset field default value on type change in Settings (twentyhq#5534) Related issue: twentyhq#5412 See twentyhq#5436 (comment) for context. commit 18fafbd Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Fri May 24 10:57:46 2024 +0200 Rename findAvailableTables endpoint (twentyhq#5557) As title commit 4bd0aaf Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Fri May 24 10:20:08 2024 +0200 [fix] Update remote table sync status in cache after schema update (twentyhq#5553) Upon schema update, sync status can change from synced to non_synced in case the update regards a table that was deleted. Let's update the sync status too to avoid displaying the table as still synchronized. https://github.com/twentyhq/twenty/assets/51697796/7ff2342b-ce9f-4179-9b76-940617cf1292 commit f9a3d5f Author: Aditya Pimpalkar <adipimpalkar@gmail.com> Date: Thu May 23 23:01:47 2024 +0100 chore: remove OAuth from chrome extension (twentyhq#5528) Since we can access the tokens directly from cookies of our front app, we don't require the OAuth process to fetch tokens anymore commit fede721 Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Thu May 23 22:36:50 2024 +0200 Add sorter for distant tables (twentyhq#5546) As title commit e00b19e Author: Jeet Desai <52026385+jeet1desai@users.noreply.github.com> Date: Thu May 23 21:56:08 2024 +0530 Change email tab placeholder illustration (twentyhq#5550) Fixes twentyhq#5502   commit fe5b558 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Thu May 23 17:00:24 2024 +0200 [FE] Update remote table schema + refactor Tables list (twentyhq#5548) Closes twentyhq#5062. Refactoring tables list to avoid rendering all toggles on each sync or schema update while using fresh data: - introducing id for RemoteTables in apollo cache - manually updating the cache for the record that was updated after a sync or schema update instead of fetching all tables again commit 0d6fe7b Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Thu May 23 14:59:34 2024 +0200 Handle relations separately for remotes (twentyhq#5538) Remote object id columns are not removed anymore when a remote object is unsynced. This is because we do not use relations anymore. We only created the id field. So the current behavior that was implemented for custom objects, to retrieve the fields to deleted, does not work. Since remote object relations are really different, I extracted the logic from `objectMetadataService`. It now handles only the relations for custom objects creation and deletion (this part should be extracted as well). I create a new remote table relation service that will: - fetch objects metadata linked to remotes (favorites, activityTargets...) - look for columns based on remote object name - delete the fields and columns commit 8019ba8 Author: Thaïs <guigon.thais@gmail.com> Date: Thu May 23 12:19:50 2024 +0200 feat: implement new SnackBar design (twentyhq#5515) Closes twentyhq#5383 ## Light theme <img width="905" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/ab0683c5-ded3-420c-ace6-684d38794a2d"> ## Dark theme <img width="903" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/4e43ca35-438d-4ba0-8388-1f061c6ccfb0"> commit 453525c Author: Jérémy M <jeremy.magrin@gmail.com> Date: Thu May 23 12:02:40 2024 +0200 fix: workspace health showing error for multi select (twentyhq#5547) Fix `workspace:health` command not working properly with `MULTI_SELECT` field metadata type. commit 7b1bea3 Author: Charles Bochet <charles@twenty.com> Date: Thu May 23 08:41:37 2024 +0200 Release patch v0.11.3 commit b8eef21 Author: Abdullah <125115953+mabdullahabaid@users.noreply.github.com> Date: Thu May 23 10:46:31 2024 +0500 [UI] Extract our ColorSample and Tag components from twenty-front to twenty-ui. (twentyhq#5543) Two more components extracted out of twenty-front: `ColorSample` and `Tag`. commit 6b1d4e0 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Thu May 23 07:43:09 2024 +0200 [Fix] Do not allow names with whitespaces (twentyhq#5542) As per title commit 04bf697 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 18:06:32 2024 +0200 feat: add feature flag to activate Links field creation (twentyhq#5535) Related issue: twentyhq#3607 commit 4e533bf Author: Weiko <corentin@twenty.com> Date: Wed May 22 17:14:33 2024 +0200 fix pgGraphqlQuery with concurent search path (twentyhq#5537) commit 5448512 Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Wed May 22 14:21:32 2024 +0200 Add quotes for table name (twentyhq#5533) As title commit 4b25181 Author: Ady Beraud <102751374+ady-beraud@users.noreply.github.com> Date: Wed May 22 15:02:54 2024 +0300 Fixed congratulations bot (twentyhq#5532) - Fixed bot - Added list of team members commit 40bd42e Author: Ady Beraud <102751374+ady-beraud@users.noreply.github.com> Date: Wed May 22 13:06:00 2024 +0300 Added Algolia Search (twentyhq#5524) -Added Algolia Search Box : <img width="707" alt="Screenshot 2024-05-22 at 10 05 13" src="https://github.com/twentyhq/twenty/assets/102751374/d26f9748-2a80-4690-88ca-16b078c52915"> -Added Algolia Search Bar: <img width="294" alt="Screenshot 2024-05-22 at 10 05 56" src="https://github.com/twentyhq/twenty/assets/102751374/ad503894-4ae1-41e4-bd4b-6241f7679142"> --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com> commit 2e79bcc Author: Thomas Trompette <thomas.trompette@sfr.fr> Date: Wed May 22 11:20:44 2024 +0200 Sync stripe tables (twentyhq#5475) Stripe tables do not support `hasNextPage` and `totalCount`. This may be because of stripe wrapper do not properly support `COUNT` request. Waiting on pg_graphql answer [here](supabase/pg_graphql#519). This PR: - removes `totalCount` and `hasNextPage` form queries for remote objects. Even if it works for postgres, this may really be inefficient - adapt the `fetchMore` functions so it works despite `hasNextPage` missing - remove `totalCount` display for remotes - fix `orderBy` --------- Co-authored-by: Thomas Trompette <thomast@twenty.com> commit 35c1f97 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 11:18:16 2024 +0200 perf: use Nx cache for Chromatic script (twentyhq#5457) Makes sure the `twenty-front:chromatic:ci` task in the CI job `front-chromatic-deployment` reuses the cache of the Storybook built in the CI job `front-sb-build` instead of re-building Storybook so Chromatic is deployed faster in the CI. commit bb6df43 Author: Jérémy M <jeremy.magrin@gmail.com> Date: Wed May 22 11:11:05 2024 +0200 fix: twentyORM datasource configuration for ssl (twentyhq#5529) We need to specify ssl configuration for TwentyORM datasources when needed, otherwise connection will be broken. commit 474dfd7 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 10:55:24 2024 +0200 fix: fix Apollo client cache update error for Links field (twentyhq#5473) Fixes twentyhq#5437 commit d1cbd70 Author: Abdullah <125115953+mabdullahabaid@users.noreply.github.com> Date: Wed May 22 13:52:35 2024 +0500 Extract typography components from twenty-front to twenty-ui. (twentyhq#5466) Removed the following components from twenty-front and moved them to twenty-ui. - H1Title. - H2Title. - H3Title. Moving components in smaller chunks to ease the process of resolving conflicts. <img width="1255" alt="image" src="https://github.com/twentyhq/twenty/assets/125115953/a3953659-5dfd-4d03-a6de-50b064129d55"> Co-authored-by: Charles Bochet <charles@twenty.com> commit e2b48e2 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 10:42:08 2024 +0200 feat: edit link in Links field (twentyhq#5447) Closes twentyhq#5376 commit 47a6146 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 10:32:37 2024 +0200 feat: set primary link in Links field (twentyhq#5429) Closes twentyhq#5375 <img width="381" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/d87773df-c685-466b-ae35-a8349f79df48"> _____ ~~Note that I ugraded `@apollo/client` to v3.10.4 because current version is causing an error when trying to write the Links field in the cache in `updateRecordFromCache` (`TypeError: Cannot convert object to primitive value`). After upgrade, the error is gone but console still prints a warning (here the custom object name is `Listing` and the Links field name is `website`):~~ <img width="964" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/834b8909-e8dc-464a-8c5a-6b7e4c964a7f"> ~~It might be because the Links field seems to somehow have a `__typename` property in Apollo's cache, so Apollo considers it as a record and tries to match the object's cache with an id, but the Links field value has no id so it can't find it. We might want to find where this `__typename` is added and remove it from the Links object in the cache.~~ Edit: will fix this in another PR as upgrading `@apollo/client` + `apollo-upload-client` seems to break types and/or tests. Related issue: [twentyhq#5437](twentyhq#5437) commit 2386191 Author: martmull <martmull@hotmail.fr> Date: Wed May 22 09:55:29 2024 +0200 Fix missing logo at sign-in-up (twentyhq#5525) ### Before  ### After  commit 944b2b0 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 09:53:15 2024 +0200 fix: reset default value on field type switch in Settings/Data Model … (twentyhq#5436) …field form Closes twentyhq#5412 commit 4800388 Author: Thaïs <guigon.thais@gmail.com> Date: Wed May 22 09:39:21 2024 +0200 feat: remove a link from a Links field (twentyhq#5313) Closes twentyhq#5117 TO FIX in another PR: right now, the "Vertical Dots" LightIconButton inside the Dropdown menu sometimes needs to be clicked twice to open the nested dropdown, not sure why 🤔 Maybe an `event.preventDefault()` is needed somewhere? <img width="369" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/dd0c771a-c18d-4eb2-8ed6-b107f56711e9"> --------- Co-authored-by: Jérémy Magrin <jeremy.magrin@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit beaaf33 Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Wed May 22 09:25:06 2024 +0200 5498 create a feature flag is gmail sync v2 enabled (twentyhq#5501) Closes twentyhq#5498 commit 5ad59b5 Author: Ady Beraud <102751374+ady-beraud@users.noreply.github.com> Date: Tue May 21 23:56:25 2024 +0300 Create congratulations bot (twentyhq#5404) - Created congratulations bot : <img width="939" alt="Screenshot 2024-05-14 at 12 47 13" src="https://github.com/twentyhq/twenty/assets/102751374/5138515f-fe4d-4c6d-9c7a-0240accbfca9"> - Modified OG image - Added png extension to OG image route To be noted: The bot will not work until the new API route is not deployed. Please check OG image with Cloudflare cache. --------- Co-authored-by: Ady Beraud <a.beraud96@gmail.com> commit 3deda2f Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Tue May 21 21:25:38 2024 +0200 Update foreign table to distant table schema (twentyhq#5508) Closes twentyhq#5069 back-end part And: - do not display schemaPendingUpdates status on remote server lists as this call will become too costly if there are dozens of servers - (refacto) create foreignTableService After this is merged we will be able to delete remoteTable's availableTables column commit 29c2780 Author: Charles Bochet <charles@twenty.com> Date: Tue May 21 20:36:25 2024 +0200 Fix vite.config duplicate cache configuration commit 36b467d Author: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com> Date: Wed May 22 02:24:08 2024 +0800 Fix storybook tests (twentyhq#5487) Fixes twentyhq#5486 --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com> commit e47101e Author: bosiraphael <71827178+bosiraphael@users.noreply.github.com> Date: Tue May 21 13:31:39 2024 +0200 5483 modify messagechannel syncstatus (twentyhq#5484) - Closes twentyhq#5483 - Fix seeds - Add default value to syncSubStatus commit 66a23a8 Author: Jérémy M <jeremy.magrin@gmail.com> Date: Tue May 21 13:29:59 2024 +0200 fix: unwanted change moving back datetime to date (twentyhq#5499) Moving back datetime to date, due to an unwanted change. commit ec248f8 Author: martmull <martmull@hotmail.fr> Date: Tue May 21 12:08:51 2024 +0200 Remove dumb code placement (twentyhq#5494) Fix a bug introduced in [this PR](https://github.com/twentyhq/twenty/pull/5254/files) When a subscription is created, we need to create the subscription, twentyhq#5254 return if no subscription is created so the sub can never be created at all This PR fixes that commit 4fcdfbf Author: martmull <martmull@hotmail.fr> Date: Tue May 21 11:31:03 2024 +0200 Fix unhandled exception (twentyhq#5474) Solves exception.getStatus is not a function error logs in twenty-server Catch all errors in order to have no error log at all commit 0d16051 Author: Marie <51697796+ijreilly@users.noreply.github.com> Date: Tue May 21 10:46:49 2024 +0200 [fix] Re-introduce beforeUpdateOneObject hook (twentyhq#5495) ... and disable name edition in object edition form. This feature will be introduced by twentyhq#5491 commit eb78be6 Author: Aditya Pimpalkar <adipimpalkar@gmail.com> Date: Tue May 21 09:39:43 2024 +0100 feat: replace iframe with chrome sidepanel (twentyhq#5197) fixes - twentyhq#5201 https://github.com/twentyhq/twenty/assets/13139771/871019c6-6456-46b4-95dd-07ffb33eb4fd --------- Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com> commit 4907ae5 Author: Félix Malfait <felix.malfait@gmail.com> Date: Tue May 21 09:09:19 2024 +0200 Improve docs (twentyhq#5492) Fix twentyhq#4382 and remove useless pages to make docs more readable
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Closes twentyhq#5382 TODO: - [x] Test all field previews in app - [x] Fix tests - [x] Fix JSON preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5382
TODO: