-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for merging a list of configs external to the second fig #10
base: master
Are you sure you want to change the base?
Conversation
I've updated the syntax slightly to make certain properties accessible, for example:
The use of the [ separates the config path from the config property since the config property may also have a . in it |
So, commands like this will now be possible:
|
This is great! I'm not too fond of the bracket notation though. Actually your point on parameter with full stops in the name is a good one as there is some ambiguity in how we treat nodes vs node properties. For example, we might have the following configuration tree:
Can we make the simplification to always assume that the last component of the override term (when split on full stops) represents the node property to set? Thoughts on that @mrolafsson? |
I would prefer the syntax to be like |
Can we ensure that the system property method is documented: http://dev.twigkit.net/docs/Getting_started/Configuration/Overlaying_configuration_values/ |
It hasn't been merged as syntax needs reviewing :) |
I have reviewed the syntax :) |
@mrolafsson @bjarkih using this syntax
and in cases where we have parent.child paths and more than one property to set:
We don't need the quotes but it would help distinguish between setting the system parameter and setting the property value. Then we use With this we avoid any ambiguity that the given property may not be unique and may not exist. |
I'd prefer it if we constructed the tree correctly whether you have dot notation in properties or not. In that case there will never be ambiguity. I know this is not the same as our custom attribute syntax but that should go way, but I would find this more readable: |
Resolves #9 @bjarkih this change is to allow the system parameter twigkit.conf.override to be implemented. Any configs given by the parameter will override any changes made through the overlay.