Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to private properties #3944

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Dec 13, 2023

No description provided.

Copy link
Contributor

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use list<Type> when items are only appended with $var[].

src/Extension/StagingExtension.php Outdated Show resolved Hide resolved
src/ExtensionSet.php Show resolved Hide resolved
src/ExtensionSet.php Show resolved Hide resolved
src/ExtensionSet.php Show resolved Hide resolved
src/Lexer.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Compiler.php Show resolved Hide resolved
src/Environment.php Outdated Show resolved Hide resolved
src/Extension/EscaperExtension.php Show resolved Hide resolved
src/RuntimeLoader/FactoryRuntimeLoader.php Outdated Show resolved Hide resolved
@fabpot fabpot force-pushed the properties-type-hints branch 3 times, most recently from 433fcbe to db8cfd8 Compare December 14, 2023 19:43
@fabpot fabpot changed the base branch from 3.x to 4.x December 14, 2023 19:43
@fabpot fabpot merged commit e8c511e into twigphp:4.x Dec 14, 2023
19 of 22 checks passed
@fabpot fabpot deleted the properties-type-hints branch December 14, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants