Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http, validate): Support thread member pagination #2119

Merged
merged 2 commits into from
Feb 9, 2023
Merged

feat(http, validate): Support thread member pagination #2119

merged 2 commits into from
Feb 9, 2023

Conversation

suneettipirneni
Copy link
Member

This adds support for the following query parameters from the list thread members endpoint:

  • after
  • limit
  • with_member

Closes #2058

@github-actions github-actions bot added c-http Affects the http crate c-validate Affects the validate crate t-feature Addition of a new feature labels Feb 5, 2023
@suneettipirneni suneettipirneni changed the base branch from next to main February 5, 2023 22:59
@suneettipirneni suneettipirneni changed the title feat(http, validate): Support query params for fetching thread members feat(http, validate): Support thread member pagination Feb 6, 2023
vilgotf
vilgotf approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMGT!
As a side note, we should really use a query param builder instead of if let Some...

@zeylahellyer zeylahellyer merged commit f9ed783 into twilight-rs:main Feb 9, 2023
@zeylahellyer
Copy link
Member

Thanks for the PR

@suneettipirneni suneettipirneni deleted the feat/add-thread-members-query-params branch February 9, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeylahellyer zeylahellyer zeylahellyer approved these changes

@vilgotf vilgotf vilgotf approved these changes

Assignees
No one assigned
Labels
c-http Affects the http crate c-validate Affects the validate crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support thread member pagination
3 participants
@suneettipirneni @zeylahellyer @vilgotf