Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(http): deprecate getreactions::exec #2135

Merged
merged 1 commit into from
Feb 11, 2023
Merged

refactor(http): deprecate getreactions::exec #2135

merged 1 commit into from
Feb 11, 2023

Conversation

zeylahellyer
Copy link
Member

Deprecate GetReactions::exec in favor of its IntoFuture implementation. This deprecation was missed in pull request #1898.

Discovered in pull request #2132.

@zeylahellyer
refactor(http): deprecate getreactions::exec
2fe37e5 
Deprecate `GetReactions::exec` in favor of its `IntoFuture`
implementation. This deprecation was missed in pull request #1898.

Discovered in pull request #2132.
@github-actions github-actions bot added c-http Affects the http crate t-refactor Refactors APIs or code. labels Feb 11, 2023
@zeylahellyer zeylahellyer mentioned this pull request Feb 11, 2023
Merged
@zeylahellyer zeylahellyer merged commit 544658b into main Feb 11, 2023
@zeylahellyer zeylahellyer deleted the zeyla/refactor-http-get-reactions-exec-deprecate branch February 11, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilgotf vilgotf vilgotf approved these changes

Assignees
No one assigned
Labels
c-http Affects the http crate t-refactor Refactors APIs or code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeylahellyer @vilgotf