Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change deny lints to warn #2144

Merged
merged 3 commits into from
Feb 17, 2023
Merged

refactor: change deny lints to warn #2144

merged 3 commits into from
Feb 17, 2023

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented Feb 15, 2023

Development of Twilight is somewhat tedious due to warning lints failing compilations of WIP changes. We should instead only fail builds once we submit them to a PR, i.e. fail in CI.
This PR removes the deny by default lints and warns on the remaining one's. Additionally I removed an uncessary allow by default unused_underscore_binding lint (useful when tracing was optional)

Suggested in #1644 (comment)

@github-actions github-actions bot added c-book Affects the book c-cache Affects the cache crate c-gateway Affects the gateway crate c-gateway-queue Affects the gateway queue crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-lavalink Affects the lavalink crate c-mention Affects the mention crate c-model Affects the model crate c-standby Affects the standby crate c-util Affects the util crate c-validate Affects the validate crate t-refactor Refactors APIs or code. labels Feb 15, 2023
@zeylahellyer zeylahellyer merged commit 463d250 into main Feb 17, 2023
@zeylahellyer zeylahellyer deleted the vilgotf/refactor/lints branch February 17, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeylahellyer zeylahellyer zeylahellyer approved these changes

@7596ff 7596ff 7596ff approved these changes

Assignees
No one assigned
Labels
c-book Affects the book c-cache Affects the cache crate c-gateway Affects the gateway crate c-gateway-queue Affects the gateway queue crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-lavalink Affects the lavalink crate c-mention Affects the mention crate c-model Affects the model crate c-standby Affects the standby crate c-util Affects the util crate c-validate Affects the validate crate t-refactor Refactors APIs or code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vilgotf @7596ff @zeylahellyer