Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gw-queue, http, model): Fix clippy up to 1.69.0 #2198

Merged
merged 2 commits into from
Apr 21, 2023
Merged

fix(gw-queue, http, model): Fix clippy up to 1.69.0 #2198

merged 2 commits into from
Apr 21, 2023

Conversation

Erk-
Copy link
Member

@Erk- Erk- commented Apr 21, 2023

allow clippy::let-underscore-untyped

@Erk-
fix(gw-queue, http, model): Fix clippy up to 1.69.0
98d7e92 
allow clippy::let-underscore-untyped
@github-actions github-actions bot added c-gateway-queue Affects the gateway queue crate c-http Affects the http crate c-model Affects the model crate t-fix Fixes a bug in the library labels Apr 21, 2023
vilgotf
vilgotf reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not instead switch to _ = <expr>? The Clippy docs point out that it's the most likely intent (adding the let is essentially a typo).

@Erk- Erk- requested a review from vilgotf April 21, 2023 07:09
@Erk- Erk- enabled auto-merge April 21, 2023 07:15
@Erk- Erk- added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit 9c74649 Apr 21, 2023
@Erk- Erk- deleted the erk/clippy-1.69.0 branch April 21, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itohatweb itohatweb itohatweb approved these changes

@vilgotf vilgotf vilgotf approved these changes

Assignees
No one assigned
Labels
c-gateway-queue Affects the gateway queue crate c-http Affects the http crate c-model Affects the model crate t-fix Fixes a bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erk- @vilgotf @itohatweb