Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump MSRV to 1.67 #2208

Merged
merged 1 commit into from
May 12, 2023
Merged

build: bump MSRV to 1.67 #2208

merged 1 commit into from
May 12, 2023

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented May 12, 2023

Bumps the MSRV from 1.64 to 1.67.

Utilizes let else statements whereever possible.

1.67 was chosen as it's the current stable - 2, which is not too recent but not too old. Specifically, it was necessary to bump the MSRV as our dependencies (in this case time) have a policy of supporting stable - 6 months (currently 1.65).

@github-actions github-actions bot added c-all Affects all crates or the project as a whole c-cache Affects the cache crate c-gateway Affects the gateway crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-lavalink Affects the lavalink crate c-mention Affects the mention crate c-model Affects the model crate c-standby Affects the standby crate c-util Affects the util crate c-validate Affects the validate crate t-build Changes that affect the build system or external dependencies labels May 12, 2023
@vilgotf vilgotf force-pushed the vilgotf/msrv-67 branch 2 times, most recently from f419e35 to 01c2918 Compare May 12, 2023 08:27
HTGAzureX1212
HTGAzureX1212 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vilgotf vilgotf added this pull request to the merge queue May 12, 2023
Merged via the queue into main with commit f199ade May 12, 2023
@vilgotf vilgotf deleted the vilgotf/msrv-67 branch May 12, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itohatweb itohatweb itohatweb approved these changes

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

Assignees
No one assigned
Labels
c-all Affects all crates or the project as a whole c-cache Affects the cache crate c-gateway Affects the gateway crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-lavalink Affects the lavalink crate c-mention Affects the mention crate c-model Affects the model crate c-standby Affects the standby crate c-util Affects the util crate c-validate Affects the validate crate t-build Changes that affect the build system or external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vilgotf @HTGAzureX1212 @itohatweb