Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http)!: fix UpdateFollowup falsely returning an EmptyBody (#2203) #2214

Merged
merged 2 commits into from
Jun 13, 2023
Merged

fix(http)!: fix UpdateFollowup falsely returning an EmptyBody (#2203) #2214

merged 2 commits into from
Jun 13, 2023

Conversation

laralove143
Copy link
Member

closes #2203

also silently fixes a small typo in attachments's

@laralove143 laralove143 added c-http Affects the http crate d-api Change related to Discord's API. labels May 26, 2023
Erk-
Erk- approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vilgotf This technically is a breaking change even if it is a bugfix so it should be highlighted if you put it out in a patch release.

@Erk- Erk- added the m-breaking change Breaks the public API. label May 27, 2023
@laralove143
Copy link
Member Author

yeah but like i said in the issue people are unlikely to use EmptyBody

@vilgotf
Copy link
Member

vilgotf commented May 27, 2023

The change only adds methods to the returned type. I doubt anyone relies on the signature, but if anybody complains we can always yank and revert

HTGAzureX1212
HTGAzureX1212 approved these changes May 27, 2023
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@laralove143
Copy link
Member Author

could someone merge this

@HTGAzureX1212 HTGAzureX1212 changed the title close #2203 fix!(http): fix UpdateFollowup falsely returning an EmptyBody (#2203) Jun 13, 2023
@Gelbpunkt Gelbpunkt changed the title fix!(http): fix UpdateFollowup falsely returning an EmptyBody (#2203) fix(http)!: fix UpdateFollowup falsely returning an EmptyBody (#2203) Jun 13, 2023
@github-actions github-actions bot added the t-fix Fixes a bug in the library label Jun 13, 2023
@Gelbpunkt Gelbpunkt added this pull request to the merge queue Jun 13, 2023
Merged via the queue into twilight-rs:main with commit eb9bde2 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

@vilgotf vilgotf vilgotf approved these changes

@Erk- Erk- Erk- approved these changes

@itohatweb itohatweb Awaiting requested review from itohatweb

Assignees
No one assigned
Labels
c-http Affects the http crate d-api Change related to Discord's API. m-breaking change Breaks the public API. t-fix Fixes a bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UpdateFollowup falsely returns EmptyBody
5 participants
@laralove143 @vilgotf @Erk- @HTGAzureX1212 @Gelbpunkt