fix(http): fix get invite query params #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-http
Gelbpunkt
approved these changes
Aug 5, 2023
|
Apologies for adding a commit after, I just saw that as well when I was playing with my bot. |
itohatweb
requested changes
Aug 27, 2023
Co-authored-by: ITOH <to@itoh.at>
itohatweb
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the GetInvite
with_counts()andwith_expiration()don't work as the query string they append uses-instead of_in the keys, as specified in the API docs - https://discord.com/developers/docs/resources/invite#get-invite-query-string-params.