Skip to content

Commit

Permalink
fix(select): background color in dark mode on windows (#3110) (#3738)
Browse files Browse the repository at this point in the history
* fix(select): background color in dark mode on windows

* fix: inherit solid color

* fix: background for inverse

(cherry picked from commit ac5a844)

Co-authored-by: Simon Taggart <me@simontaggart.com>
  • Loading branch information
raffaele-abramini and SiTaggart committed Jan 30, 2024
1 parent 134fa9e commit 36f33dc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changeset/strange-spoons-hear.md
@@ -0,0 +1,6 @@
---
'@twilio-paste/select': patch
'@twilio-paste/core': patch
---

[Select] Fixed a bug in dark mode on Windows where the options list was still white and the options were unreadable
3 changes: 2 additions & 1 deletion packages/paste-core/components/select/src/Select.tsx
Expand Up @@ -30,7 +30,8 @@ export const SelectElement = React.forwardRef<HTMLSelectElement, SelectProps>(
// We want the size attribute on the HTML element to set the height, not the css
height={undefined}
appearance="none"
backgroundColor="transparent"
// must set a solid color to inherit in options for Windows
backgroundColor={variant === 'inverse' ? 'colorBackgroundInverse' : 'colorBackgroundBody'}
border="none"
borderRadius="borderRadius20"
boxShadow="none"
Expand Down

0 comments on commit 36f33dc

Please sign in to comment.