fix(menu): href not being spread to MenuItem (#2634)

* chore: fix href not spread to menu item * chore: add changeset Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
twilio-labs · Aug 24, 2022 · ceb26bb · ceb26bb
1 parent 05ae02d
commit ceb26bb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/twelve-ducks-own.md b/.changeset/twelve-ducks-own.md
@@ -0,0 +1,6 @@
+---
+'@twilio-paste/menu': patch
+'@twilio-paste/core': patch
+---
+
+[Menu] fix href not getting passed to MenuItem
diff --git a/packages/paste-core/components/menu/__tests__/index.spec.tsx b/packages/paste-core/components/menu/__tests__/index.spec.tsx
@@ -97,6 +97,7 @@ describe('Menu', () => {
       render(<MenuMock />);
       const renderedMenuItem = screen.getByTestId('example-menu-anchor');
       expect(renderedMenuItem.tagName).toEqual('A');
+      expect(renderedMenuItem.getAttribute('href')).toEqual('https://google.com');
     });
 
     it('should render a menu separator', () => {

diff --git a/packages/paste-core/components/menu/src/MenuItem.tsx b/packages/paste-core/components/menu/src/MenuItem.tsx
@@ -11,6 +11,7 @@ export const StyledMenuItem = React.forwardRef<HTMLDivElement | HTMLAnchorElemen
     return (
       <Box
         {...(href && secureExternalLink(href))}
+        href={href}
         as={href ? 'a' : 'button'}
         {...safelySpreadBoxProps(props)}
         element={element}