-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(design-tokens): update some blues, reds, and focus shadow #185
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/twilio-dsys/paste/ixc6enf3z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For SendGrid, it looks like the values for color-border-primary-dark
and color-border-primary-darker
need to match the same values for the background-colors... you can notice the border color is a touch lighter than the background color.
color-background-primary-dark
& color-border-primary-dark
should map to blue-70
color-background-primary-darker
& color-border-primary-darker
should map to blue-80
e7236ba
to
d00ae31
Compare
Fixes for SG:
Fixes for Console:
sorry 😰 |
More changes because buttons looked weird:
|
## Blues transparent based on primary blue | ||
palette-blue-60-transparent-10: "rgba(2, 123, 200, 0.1)" | ||
palette-blue-60-transparent-20: "rgba(2, 123, 200, 0.2)" | ||
palette-blue-60-transparent-30: "rgba(2, 123, 200, 0.3)" | ||
palette-blue-60-transparent-40: "rgba(2, 123, 200, 0.4)" | ||
palette-blue-60-transparent-50: "rgba(2, 123, 200, 0.5)" | ||
palette-blue-60-transparent-60: "rgba(2, 123, 200, 0.6)" | ||
palette-blue-60-transparent-70: "rgba(2, 123, 200, 0.7)" | ||
palette-blue-60-transparent-80: "rgba(2, 123, 200, 0.8)" | ||
palette-blue-60-transparent-90: "rgba(2, 123, 200, 0.9)" | ||
palette-blue-60-transparent-100: "rgba(2, 123, 200, 1)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the blue-60
change, the rgb value needs to change to 2, 122, 197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
@@ -43,10 +43,10 @@ props: | |||
|
|||
# primary background | |||
color-background-primary-darker: | |||
value: "{!palette-blue-70}" | |||
value: "{!palette-blue-90}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be blue-80
comment: Darker background for primary actions or highlights | ||
color-background-primary-dark: | ||
value: "{!palette-blue-60}" | ||
value: "{!palette-blue-80}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be blue-70
@@ -31,10 +31,10 @@ props: | |||
value: "{!palette-blue-40}" | |||
comment: Light shade of link text to be used in interactions | |||
color-text-link-dark: | |||
value: "{!palette-blue-70}" | |||
value: "{!palette-blue-80}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be blue-70
comment: Dark shade of link text to be used in interactions | ||
color-text-link-darker: | ||
value: "{!palette-blue-80}" | ||
value: "{!palette-blue-90}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be blue-80
What changed: