chore(avatar): allow both src and icon prop to be passed #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39dcaed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Status: Do Not Merge
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 39dcaed:
|
|
Size Change: -63 B (0%) Total Size: 534 kB
ℹ️ View Unchanged
|
shleewhite
force-pushed
the
fix/icon-types
branch
from
be08c82
to
878882c
Compare
TheSisb
approved these changes
Jun 7, 2022
shleewhite
force-pushed
the
fix/icon-types
branch
from
878882c
to
cdce759
Compare
TheSisb
reviewed
Jun 7, 2022
| @@ -199,6 +205,10 @@ The Avatar `size` can be set as a responsive array of sizes. | |||
| </Stack>`} | |||
| </LivePreview> | |||
|
|
|||
| ## Composition Notes | |||
|
|
|||
| The Avatar displays its contents in this priority: icon, then image, then initials. | |||
SiTaggart
approved these changes
Jun 7, 2022
shleewhite
added
🕵🏻♀️ Run website visual regression
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made for: #2437
We want to allow users to pass both src and icon so that they can display one or the other depending on if the image loads correctly.
This PR includes:
Contributing to Twilio