fix(combobox): controlled autocomplete cursor placement onInputValueChange bug #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4326a80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 50e9a4e:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Size Change: +61 B (0%) Total Size: 639 kB
ℹ️ View Unchanged
|
TheSisb
reviewed
Aug 27, 2022
packages/paste-core/components/combobox/stories/index.stories.tsx
Outdated
Show resolved
Hide resolved
If we decide not to add the workaround prop, I think we should at least fix it on the docs site. Seems like people are looking at that example, so it'd be good to at least have it working there. |
SiTaggart
force-pushed
the
fix/combobox-controlled-autocomplete
branch
from
a6f9303
to
70e9b8d
Compare
github-actions
bot
removed
the
Type: Documentation
Yeah, planning on just having "the correct docs" as the fix to the problem after further investigating this. |
gloriliale
reviewed
Aug 31, 2022
gloriliale
reviewed
Aug 31, 2022
SiTaggart
force-pushed
the
fix/combobox-controlled-autocomplete
branch
from
70e9b8d
to
50e9a4e
Compare
github-actions
bot
added
the
Type: Documentation
|
Fixes #2618 |
SiTaggart
removed
the
Status: Do Not Merge
serifluous
changed the title
TheSisb
dismissed stale reviews from gloriliale, nkrantz, and themself
via
50e9a4e
serifluous
reviewed
Sep 6, 2022
nkrantz
previously approved these changes
Sep 7, 2022
SiTaggart
force-pushed
the
fix/combobox-controlled-autocomplete
branch
from
50e9a4e
to
4326a80
Compare
TheSisb
approved these changes
Sep 7, 2022
nkrantz
approved these changes
Sep 7, 2022
serifluous
approved these changes
Sep 7, 2022
gloriliale
approved these changes
Sep 7, 2022
SiTaggart
added
the
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super annoying bug in Downshift that's been open for 2 years. downshift-js/downshift#1108
They actually, kind of allude to it here in the Github docs https://github.com/downshift-js/downshift#oninputvaluechange, where they link to some old issue and some hints towarsds a fix.
Basically, we're doing it wrong. If you're trying to use the combobox in a controlled mannor, you should be using
defaultInputValue, notinputValue, and let Downshift manage the internal state afterwards. We re-mapinputValuetodefaultInputValueto address this. This should have no detrimental impact to the consumer and should just "fix the problem" with no code changes.For folks using the hook, we're doing it wrong again. You want to set the initial value and selected item, and let Downshift take over from there. In this case I have just updated the Docs example.