Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

verifyToken received by requestSms fails after update to v3.0 #57

Closed
orbex opened this issue Aug 23, 2018 · 7 comments
Closed

verifyToken received by requestSms fails after update to v3.0 #57

orbex opened this issue Aug 23, 2018 · 7 comments
Assignees
Labels

Comments

@orbex
Copy link

orbex commented Aug 23, 2018

Trying to upgrade from v2.2 to v3.0
Able to receive a token (int in v3.0, was string in v2.2) via SMS, but when verifying given token, API returns "token invalid"...
Is there a changelog somewhere I can read through to try to find (breaking) changes ?
Have already gone through the docs at https://www.twilio.com/docs/authy ...

@orbex orbex closed this as completed Aug 29, 2018
@orbex
Copy link
Author

orbex commented Sep 6, 2018

Bug:
authy_v3_token_sms
While testing the new code, I received a token from the API which started with a zero (see screenshot).
This token cannot pass the new __validateVerify() function as it needs to be captured as a string to retain the first zero.

Issue reopened

@orbex orbex reopened this Sep 6, 2018
@luisuribe luisuribe added the bug label Sep 6, 2018
@luisuribe luisuribe self-assigned this Sep 6, 2018
@orbex
Copy link
Author

orbex commented Apr 17, 2019

Has this ever been resolved ?

@DevOwais
Copy link

facing the same issue, what's the status? is it fixed or not ?

@luisuribe
Copy link
Contributor

Hi, sorry for the late reply. This is in our timeline for next release that will happen next week.

@luisuribe
Copy link
Contributor

So, I was taking a look at this and couldn't reproduce the issue. Using https://github.com/luisuribe/authy-sample-app I did some tests with a token starting with zero and it works.

Could you please share some code so we can check and maybe find a solution?

Also, please have in mind that from 2.2 to 3.0 there's a lot of changes (sadly without a changelog, but that's going to change) that could cause your app to stop working.

@DevOwais
Copy link

DevOwais commented May 1, 2019 via email

@orbex
Copy link
Author

orbex commented May 6, 2019

Hi @luisuribe,
thanks for checking things out and supplying your sample-app which pointed me in the right direction :)
Solved the issue by removing any and all casting of $token that was done by our own code.

Resolved

@orbex orbex closed this as completed May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants