Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added the github actions to send the slack notifications #164

Merged
merged 2 commits into from
Oct 12, 2021
Merged

feat: Added the github actions to send the slack notifications #164

merged 2 commits into from
Oct 12, 2021

Conversation

ravali-rimmalapudi
Copy link
Contributor

@ravali-rimmalapudi ravali-rimmalapudi commented Oct 6, 2021 •
edited
Loading

Fixes

Closes: DII-131
Dependent PRs: CLI, Homebrew

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

This was referenced Oct 6, 2021
Merged
Merged
sr010
sr010 previously approved these changes Oct 6, 2021
View reviewed changes
@sr010
Copy link
Contributor

sr010 commented Oct 6, 2021 •
edited
Loading

Can you please add screenshots?

@ravali-rimmalapudi
Copy link
Contributor Author

Can you please add screenshots?

Added the screenshots in CLI: Link

shrutiburman
shrutiburman reviewed Oct 6, 2021
View reviewed changes
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
onuzbee
onuzbee approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@onuzbee onuzbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrutiburman
shrutiburman approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ravali-rimmalapudi ravali-rimmalapudi merged commit 06e2cb1 into main Oct 12, 2021
@ravali-rimmalapudi ravali-rimmalapudi deleted the slack_notifications branch October 12, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kridai kridai kridai approved these changes

@onuzbee onuzbee onuzbee approved these changes

@shrutiburman shrutiburman shrutiburman approved these changes

@sr010 sr010 sr010 approved these changes

@Sindhura3 Sindhura3 Awaiting requested review from Sindhura3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ravali-rimmalapudi @sr010 @kridai @onuzbee @shrutiburman