Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install should check node version #3

Closed
dprothero opened this issue Oct 1, 2018 · 1 comment · Fixed by #208
Closed

Install should check node version #3

dprothero opened this issue Oct 1, 2018 · 1 comment · Fixed by #208
Labels
status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Comments

@dprothero
Copy link
Contributor

Install should check node version before proceeding and upgrade if needed

WARNING
WARNING Node version must be >=8.0.0 to use this CLI
WARNING Current node version: 6.14.3
WARNING
/usr/local/lib/node_modules/twilio-cli/node_modules/@oclif/command/lib/command.js:23
    async _run() {
          ^^^^```
childish-sambino pushed a commit that referenced this issue Apr 29, 2019
@dprothero
Merge pull request #3 from twilio/mv-utility-services2
22d6c06 
Missed renaming test/utility to test/services
@thinkingserious thinkingserious added status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Mar 17, 2020
@childish-sambino
Copy link
Contributor

Apparently this is really easy: https://www.stefanjudis.com/today-i-learned/prevent-npm-install-for-not-supported-node-js-versions/ (we know that guy!)

@childish-sambino childish-sambino added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap and removed status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Jul 29, 2020
@childish-sambino childish-sambino mentioned this issue Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: block installation via npm when Node.js requirement not met twilio/twilio-cli
3 participants
@thinkingserious @dprothero @childish-sambino