Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add xz compression for tarballs #321

Merged
merged 1 commit into from
Nov 2, 2021
Merged

chore: Add xz compression for tarballs #321

merged 1 commit into from
Nov 2, 2021

Conversation

onuzbee
Copy link
Contributor

@onuzbee onuzbee commented Nov 2, 2021

Fixes

Add xz compression for tarballs.
Sample run npx oclif-dev pack --xz:

Note: This PR also removes git pre-run hook due to known audit issues with the repo.

oclif-dev: packing tarball from ./tmp/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1.tar.gz
tar: Failed to set default locale
oclif-dev: packing tarball from ./tmp/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1.tar.xz
tar: Failed to set default locale
oclif-dev: building target twilio-v2.32.1-linux-x64.tar.gz
oclif-dev: packing tarball from ./tmp/linux-x64/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-linux-x64.tar.gz
tar: Failed to set default locale
oclif-dev: packing tarball from ./tmp/linux-x64/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-linux-x64.tar.xz
tar: Failed to set default locale
oclif-dev: building target twilio-v2.32.1-linux-arm.tar.gz
oclif-dev: packing tarball from ./tmp/linux-arm/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-linux-arm.tar.gz
tar: Failed to set default locale
oclif-dev: packing tarball from ./tmp/linux-arm/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-linux-arm.tar.xz
tar: Failed to set default locale
oclif-dev: building target twilio-v2.32.1-win32-x64.tar.gz
oclif-dev: packing tarball from ./tmp/win32-x64/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-win32-x64.tar.gz
tar: Failed to set default locale
oclif-dev: packing tarball from ./tmp/win32-x64/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-win32-x64.tar.xz
tar: Failed to set default locale
oclif-dev: building target twilio-v2.32.1-win32-x86.tar.gz
oclif-dev: packing tarball from ./tmp/win32-x86/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-win32-x86.tar.gz
tar: Failed to set default locale
oclif-dev: packing tarball from ./tmp/win32-x86/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-win32-x86.tar.xz
tar: Failed to set default locale
oclif-dev: building target twilio-v2.32.1-darwin-x64.tar.gz
oclif-dev: packing tarball from ./tmp/darwin-x64/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-darwin-x64.tar.gz
tar: Failed to set default locale
oclif-dev: packing tarball from ./tmp/darwin-x64/twilio to ./dist/twilio-v2.32.1/twilio-v2.32.1-darwin-x64.tar.xz

Testing

Tested generating the xz compressed tarball, and installing for basic usage.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@onuzbee onuzbee merged commit 9bd5494 into main Nov 2, 2021
@onuzbee onuzbee deleted the compress-tarball branch November 2, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants