Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ngrok warning and prompt when creating phone number tunnels #89

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

childish-sambino
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.09%.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #89     +/-   ##
========================================
- Coverage   98.69%   98.6%   -0.1%     
========================================
  Files          26      26             
  Lines         766     787     +21     
========================================
+ Hits          756     776     +20     
- Misses         10      11      +1
Impacted Files Coverage Δ
src/commands/phone-numbers/update.js 95.91% <92.85%> (-4.09%) ⬇️
src/commands/profiles/remove.js
src/commands/profiles/add.js
src/commands/profiles/list.js
src/commands/profiles/use.js
src/commands/projects/add.js 97.97% <0%> (ø)
src/commands/projects/remove.js 100% <0%> (ø)
src/commands/projects/list.js 100% <0%> (ø)
src/commands/projects/use.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6b9de...481dfd7. Read the comment docs.

Copy link
Contributor

@aroach aroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino merged commit 8d8859a into master Aug 2, 2019
@childish-sambino childish-sambino deleted the ngrok-warning branch August 2, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants