fix: request validator logic #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
claudiachua
changed the title
rakatyal
reviewed
Jul 11, 2022
README.md
Outdated
| ) | ||
|
|
||
| func main() { | ||
| // For this example: TWILIO_AUTH_TOKEN := "12345" |
There was a problem hiding this comment.
Don't see the significance of this comment, should rather change to:
"You can find your Auth Token at twilio.com/console"
There was a problem hiding this comment.
For the validation in line 466/474 to work (to return True) in the given example, the Auth_Token must be 12345. I could add in another line to include where they can find their AuthToken
rakatyal
added a commit
that referenced
this pull request
Sep 28, 2022
* docs: prep for RC release * [Librarian] Regenerated @ a300182f597e1050bc57f110ad212d20083b58e4 * Release v1.0.0-rc.1 * test: edit regex for rc naming for useragent tests (#169) * [Librarian] Regenerated @ b1da2810ac9def6e9282b52c1aa794ebefde64e0 * Release v1.0.0-rc.2 * fix: request validator logic (#173) * [DI-1324] fixed request validation logic * fix: useragent regrex unit test for RC branch (#175) * [DI-2164] modify unit test for RC branch * [Librarian] Regenerated @ 85d420e85461ff1892d00b72852ff7e138514cbc * Release v1.0.0-rc.3 * fix: Support older Go version (#176) * release fix to support older go versions * [Librarian] Regenerated @ 85d420e85461ff1892d00b72852ff7e138514cbc * Release v1.0.0-rc.4 * docs: mark latest 'Verify' change as breaking * [Librarian] Regenerated @ 54f479b2e9ba3ddad939d35c077bf4875093bb86 * Release v1.0.0-rc.5 * fix: correct the docker tag syntax for RCs * test: add datarace detection for go (#179) * test: Include a cluster test for Request Validator (#178) * test: Include a cluster test for Request Validator * test: fix for linting failures and using the proper PR branch (#180) * [Librarian] Regenerated @ 9e43c4b1c21f11427158cfc8a409854c419cd158 * Release v1.0.0-rc.6 * test: add test-docker rule (#182) * test: add test-docker rule * Adding support for go 1.19 (#185) * [Librarian] Regenerated @ 9419ae9766a1f3421c32308ef0a457ca0c0248fd * Release v1.0.0-rc.7 * feat: add twiml support (#186) Co-authored-by: cchua <cchua@twilio.com> * chore: Changes to TwiML (#187) * Change Nouns to InnerElements * Modify functions to recieve/return both response and error * [Librarian] Regenerated @ ade563fc57a4dee06c74dd93e9921a155b4c5a44 * Release v1.0.0-rc.8 * test: Added tests for twiml package (#188) * docs: Add upgrade guide for 1.x.x (#189) * Renaming openapi to twilioApi in Readme examples (#190) * docs: update upgrade guide date Co-authored-by: childish-sambino <sharrison@twilio.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com> Co-authored-by: Jennifer Mah <42650198+JenniferMah@users.noreply.github.com> Co-authored-by: Claudia Chua <43133161+claudiachua@users.noreply.github.com> Co-authored-by: Bilal Boussayoud <bboussayoud@twilio.com> Co-authored-by: cchua <cchua@twilio.com> Co-authored-by: Hunga1 <awhung99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #139 #137
Internal Jira Link: DI-1324