This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Call the incoming push completion handler when the call is reported to CallKit #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushtank
reviewed
Dec 26, 2018
piyushtank
approved these changes
Dec 26, 2018
This was referenced Dec 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the updates is to fix an issue where CallKit calls are not properly shown to the users when the app is in the background or terminated. The issue happens when reporting the call to CallKit and calling the incoming-push completion handler at the same time (when the app is not in the foreground). For some reason the CallKit reporting method gets stuck and won't fire the completion block in this scenario. The fix relieves the problem by only calling the incoming-push-completion when the call is reported.
Save the completion handler of the
pushRegistry:didReceiveIncomingPushWithPayload:forType:withCompletionHandler:method and call when the call is properly reported to CallKit and handled.