Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support: Ruby 2.6, 2.5, 2.4, drop 2.2, 2.3 #127

Merged
merged 5 commits into from
Jan 31, 2019
Merged

Support: Ruby 2.6, 2.5, 2.4, drop 2.2, 2.3 #127

merged 5 commits into from
Jan 31, 2019

Conversation

jage
Copy link
Contributor

@jage jage commented Jan 30, 2019

2.2 and 2.3 has lost their support.

jage and others added 5 commits January 30, 2019 17:48
@jage
Support: Ruby 2.6, 2.5, 2.4, drop 2.2, 2.3
19767aa 
2.2 and 2.3 has lost their support.
@dentarg
Drop JRuby 9.0.5.0
1032b64 
This version of JRuby matches Ruby 2.2.x, which is not supported
anymore. https://www.jruby.org/2016/01/26/jruby-9-0-5-0.html
@dentarg
Bump JRuby to the version we are using
5509426
@dentarg
Bump to Ruby 2.4.5
4b7325b
@dentarg
Drop JRuby 9.1.7.0, test JRuby 9.2.5.0
70844df 
This version of JRuby matches Ruby 2.3.x, which is not supported
anymore. https://www.jruby.org/2018/04/23/jruby-9-1-17-0

JRuby 9.2.5.0 matches Ruby 2.5.x.
https://www.jruby.org/2018/12/06/jruby-9-2-5-0.html
@walro
Copy link
Contributor

walro commented Jan 31, 2019 •
edited
Loading

Feels a bit weird to drop support for the JRuby series (9.1.x) we're using in some project(s). I guess the middle ground would be to just drop 2.2/9.0 support for now.

Concerning JRuby, it seems like they are still offering 9.1 without stuffing it into earlier releases at least: https://www.jruby.org/download

@walro
Copy link
Contributor

walro commented Jan 31, 2019

Moreover, 2.3 loses its support on 2019-03-31.

@dentarg
Copy link
Collaborator

dentarg commented Jan 31, 2019

Feels a bit weird to drop support for the JRuby series (9.1.x) we're using in some project(s).

Yeah, I had that feeling too. I did check, and we are not using twingly-url in our JRuby 9.1.x project (bruce). I think it is unlikely we will start doing it soon.

Moreover, 2.3 loses its support on 2019-03-31.

Yeah, I saw it too (after my commits), that 2.3 is still supported... but as we don't use 2.3 anywhere, I'm ok with dropping it now.

@walro
Copy link
Contributor

walro commented Jan 31, 2019

We will likely move to >= 9.2 for JRuby "soon" anyway.

@dentarg
Copy link
Collaborator

dentarg commented Jan 31, 2019

Yes

@jage
Copy link
Contributor Author

jage commented Jan 31, 2019

Yeah, I saw it too (after my commits), that 2.3 is still supported... but as we don't use 2.3 anywhere, I'm ok with dropping it now.

Yeah, and AFAIK 2.3 is in "security maintenance" (vs. normal maintenance for 2.4).

Currently in security maintenance phase. We will never backport any bug fixes to 2.3 except security fixes. If a critical security issue is found, we will release an urgent fix for it. We are planning to end the support of the Ruby 2.3 series at the end of March 2019.

https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/

@jage jage merged commit 75ed523 into master Jan 31, 2019
@jage jage deleted the bump-ruby-versions branch January 31, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walro walro walro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jage @walro @dentarg