Make sure we always read PSL data as UTF-8 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walro
reviewed
Sep 19, 2016
| @@ -1,3 +1,4 @@ | |||
| require "addressable/idna" | |||
There was a problem hiding this comment.
Was this missing from before? I don't see how it's used now?
There was a problem hiding this comment.
This was missing from before, and the specs will fail without it (because the spec runs this file directly – it was required indirectly before)
There was a problem hiding this comment.
We do Addressable::IDNA.to_ascii here (from before, not added in this PR – but there were no specs then, so it made sense to include it in the commit creating the spec file)
There was a problem hiding this comment.
Thanks, didn't check the full file before so I didn't spot the call to to_ascii.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #98.