#40 Publish to PyPi using GitHub Actions #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First commit is just for testing, to see if the API works |
adiroiban
force-pushed
the
40-fix-pypi-publish
branch
from
61d8725
to
5224b5a
Compare
graingert
reviewed
Oct 30, 2023
adiroiban
force-pushed
the
40-fix-pypi-publish
branch
from
9743bb8
to
3ab22f5
Compare
adiroiban
force-pushed
the
40-fix-pypi-publish
branch
from
3ab22f5
to
e5d3e14
Compare
adiroiban
commented
Oct 30, 2023
| @@ -179,7 +187,7 @@ jobs: | |||
|
|
|||
| - name: Publish to PyPI - on tag | |||
| if: startsWith(github.ref, 'refs/tags/') | |||
| uses: pypa/gh-action-pypi-publish@a56da0b891b3dc519c7ee3284aff1fad93cc8598 | |||
| uses: pypa/gh-action-pypi-publish@release/v1 | |||
There was a problem hiding this comment.
I went with the automatically updated version here.
Since constantly is not that active, I think is ok to pin to the tag
adiroiban
commented
Oct 30, 2023
| @@ -42,3 +42,6 @@ versionfile_source = "constantly/_version.py" | |||
| versionfile_build = "constantly/_version.py" | |||
| tag_prefix = "" | |||
| parentdir_prefix = "constantly-" | |||
|
|
|||
| [bdist_wheel] | |||
| universal=0 | |||
There was a problem hiding this comment.
so that py2 wheels are not generated
twm
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
It was the
ci.yaml vs ci.ymlbut also the write permission for the token was missing.A push to testing looks ok ... it fails as the version was not ok, as it was not generated for a tag.
https://github.com/twisted/constantly/actions/runs/6690686556/job/18176460120?pr=41#step:8:20
I don't know how to override versioneer: python-versioneer/python-versioneer#199