-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't build readthedocs epub #190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
===========================================
+ Coverage 83.28% 93.63% +10.34%
===========================================
Files 87 74 -13
Lines 11567 10420 -1147
Branches 1184 1071 -113
===========================================
+ Hits 9634 9757 +123
+ Misses 1815 544 -1271
- Partials 118 119 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am +1 since I hope that with this we get a green Read the docs badge.
I like to check the readme or github repo start page and see the status of all the tests.
I now see that we don't run the read the docs tests on a merge in master.
Not sure if that is on purpose... or this is how read that docs works
Does read the docs run the commit tests only for a PR, or it can also run the tests and send a commit status for a push/merge?
The readthedocs badge is already green |
If Read the docs is not creating the EPUB during a PR tests, I think is best have this merged. Thanks! |
I'm 👍 on green checkmarks |
I would have merged this but python3.6 has been removed from github actions so the build config needs to be updated first :( |
Going to push this through, it removal of epub creation which has no effect on code itself. |
Change suggested by @adiroiban, I'm -0 on this as it's not doing too much harm
Contributor Checklist:
docs/source/NEWS.rst
CONTRIBUTING.rst
.