Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't build readthedocs epub #190

Merged
merged 2 commits into from
Feb 4, 2022
Merged

don't build readthedocs epub #190

merged 2 commits into from
Feb 4, 2022

Conversation

graingert
Copy link
Member

Change suggested by @adiroiban, I'm -0 on this as it's not doing too much harm

Contributor Checklist:

  • I have updated the release notes at docs/source/NEWS.rst
  • I have updated the automated tests.
  • All tests pass on your local dev environment. See CONTRIBUTING.rst.

@graingert graingert changed the title doin't build readthedocs epub don't build readthedocs epub Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #190 (641e843) into master (df81510) will increase coverage by 10.34%.
The diff coverage is n/a.

❗ Current head 641e843 differs from pull request most recent head 84ece14. Consider uploading reports for the commit 84ece14 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #190       +/-   ##
===========================================
+ Coverage   83.28%   93.63%   +10.34%     
===========================================
  Files          87       74       -13     
  Lines       11567    10420     -1147     
  Branches     1184     1071      -113     
===========================================
+ Hits         9634     9757      +123     
+ Misses       1815      544     -1271     
- Partials      118      119        +1     
Impacted Files Coverage Δ
ldaptor/usage.py 69.35% <0.00%> (-11.30%) ⬇️
ldaptor/protocols/pureber.py 89.03% <0.00%> (-1.72%) ⬇️
ldaptor/protocols/ldap/ldapsyntax.py 93.05% <0.00%> (-1.20%) ⬇️
ldaptor/protocols/ldap/ldapserver.py 80.98% <0.00%> (-0.87%) ⬇️
ldaptor/protocols/ldap/ldifdelta.py 89.90% <0.00%> (-0.84%) ⬇️
ldaptor/ldiftree.py 88.92% <0.00%> (-0.64%) ⬇️
ldaptor/entry.py 94.66% <0.00%> (-0.37%) ⬇️
ldaptor/dns.py 93.47% <0.00%> (ø)
ldaptor/config.py 74.28% <0.00%> (ø)
ldaptor/checkers.py 0.00% <0.00%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f992a...84ece14. Read the comment docs.

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 since I hope that with this we get a green Read the docs badge.

I like to check the readme or github repo start page and see the status of all the tests.

I now see that we don't run the read the docs tests on a merge in master.
Not sure if that is on purpose... or this is how read that docs works

Does read the docs run the commit tests only for a PR, or it can also run the tests and send a commit status for a push/merge?

image

@graingert
Copy link
Member Author

I am +1 since I hope that with this we get a green Read the docs badge.

The readthedocs badge is already green

@adiroiban
Copy link
Member

If Read the docs is not creating the EPUB during a PR tests, I think is best have this merged. Thanks!

@glyph
Copy link
Member

glyph commented Jan 11, 2022

I'm 👍 on green checkmarks

@glyph
Copy link
Member

glyph commented Jan 11, 2022

I would have merged this but python3.6 has been removed from github actions so the build config needs to be updated first :(

@psi29a psi29a merged commit 4bfe289 into twisted:master Feb 4, 2022
@psi29a
Copy link
Contributor

psi29a commented Feb 4, 2022

Going to push this through, it removal of epub creation which has no effect on code itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants