Explain requirements 43 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configuration to use this information to perform some extra builds against various versions of Twisted.
…cifically, to be happy with either Twisted <14 or Twisted >=14 behavior.
Closed
|
Thanks for working on this @mithrandi :) |
|
@glyph: Travis is green now, can you weigh in as a reviewer here too? (since I've "tainted" the branch now with the last two commits) |
| """ | ||
| Return the number of distinct headers present. | ||
| """ | ||
| # XXX Too many _ |
There was a problem hiding this comment.
file a ticket or accept your fate, never use an XXX comment :)
There was a problem hiding this comment.
This is copied verbatim from Twisted; my plan is to remove the code again once this functionality is removed from Nevow for good, rather than maintain it, but there should be a ticket about this so I'll file one.
|
Other than my one minor nitpick, |
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just exarkun's changes with the conflict resolved. Fixes #43.