Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for missing baseobjects #483

Conversation

not-my-profile
Copy link
Contributor

This is just a workaround that seems to work. If we fix our AST builder to be reproducible we can probably just remove this, but for now it should fix the missing base classes.

Closes #482.

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #483 (f9f4fc4) into master (5ed88ac) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   89.49%   89.47%   -0.03%     
==========================================
  Files          34       34              
  Lines        6225     6230       +5     
  Branches     1410     1414       +4     
==========================================
+ Hits         5571     5574       +3     
- Misses        398      399       +1     
- Partials      256      257       +1     
Impacted Files Coverage Δ
pydoctor/driver.py 66.26% <60.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed88ac...f9f4fc4. Read the comment docs.

@tristanlatr
Copy link
Contributor

Not too sure about this workaround... In any case, it should come with a test.

You could put this code inside the post processing method of the system instead of the driver. It’s not currently the best place for that.

Also, I’m working on a another project that should replace our ast builder. See #430. So this issue will be properly fixed with this refactor hopefully. But it’s good to have it fixed like that too. Actually it’s perfect if we can have a solid test case.

talk to you later

@not-my-profile
Copy link
Contributor Author

Oh I think I discovered the root cause for the lack of reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's a random chance that the superclass isn't linked
2 participants