-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore backup files #556
Comments
If someone will send a good PR to ignore any files that are not in git, we can merge it :) To me it makes sense to ignore the files that are not in git. towncrier is all about gathering the files from multiple branches. |
This would contradict the changes in #357, so if we're saying that we definitely won't handle untracked files in future, then that should be closed. If we do go this way, then a quick search suggests a simple solution could be to run |
Which would also solve #448 easily. |
So, I reckon just replacing towncrier/src/towncrier/_builder.py Line 104 in 0b023fa
With a git call to |
Sound very good. Thanks. Anythig that has good automated tests and doesn't break the current test suite should be good enogh to be merged. We are already calling Also, as we are going to call |
From #448 (comment)
I get an error when it fails to git remove some hidden backup files on my computer.
Personally, I'd be fine if it simply skipped any files which are not committed, but I see there are planned changes to go in the other direction, in which case simply ignoring common backup files would be fine too.
The backup files in my case all end with
~
. This is a common pattern on Linux systems and are treated as hidden files by a lot of software (similar to starting with.
).The text was updated successfully, but these errors were encountered: