-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle deletion of uncommitted news fragments #357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #357 +/- ##
==========================================
- Coverage 99.84% 92.80% -7.05%
==========================================
Files 13 11 -2
Lines 631 500 -131
Branches 146 101 -45
==========================================
- Hits 630 464 -166
- Misses 0 18 +18
- Partials 1 18 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the changes.
They look good.
I left a few minor comments regarding the documentation/docstrings of these changes.
I would like to keep the _run
helper private and outside of the git code :)
Sorry for the late review.
I hope you will still have time to drive this PR.
Let me know if you are no longer interested in working on it and I will try to take over and finalize this PR.
Cheers
It looks like this issue has gotten a little stale, and since we haven't heard back from the contributor, I'm going to close it for now. If you'd like to revive the effort, feel free to ping this PR and we can re-open, or start a new one. Thanks. |
Hey folks! Sorry I had totally forgotten about this PR. I'll try to find some time to finalize it, if it's still relevant. |
Could you please reopen @jaraco ? |
Thanks for the update. Can you please fix the conflicts and update the docstring for We no longer support python 2.7 |
ec709a8
to
5ee3f19
Compare
I'm more than happy to remove Python 2.7 remnants :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
I think that we are very close to being able to merge this.
But this needs more cleanup.
The commented lines in the test file are a blocker.
Thanks again.
I've made the changes, thanks a lot for your patience. FYI I do appreciate the in-depth reviews, even for minor style changes. I'm frequently on the other end of those ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the command line docs say:
By default, the processed news fragments are removed using git, which will also remove the fragments directory if now empty.
This should be updated. Maybe something like
By default, the processed news fragments are removed. For any fragments committed in your git repository,
git rm
will be used (which will also remove the fragments directory if now empty).
Before this commit, all the news fragments needed to be committed into git, or the fragments removal after building the news file would crash. In my workflow, I add missing fragments before building the news file because I'm extracting author names from the git log, and towncrier crashes at the end of the build process. Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Thanks for the update. I will let Chris do the final review and approval for this PR. @abompard Note that we merge with squash. Cheers |
Ah, sorry about that, I didn't know. FYI, I've had this same issue many times (trying to review PRs that rebase/rewrite) and I ended up writing a small tool to help me with the workflow: https://pypi.org/project/git-pr-branch/. The main idea is that it will download the different revisions of a PR in different branches that you can diff, even if it's always 1 commit that's being rebased. |
No problem. For most of the reviews, I don't checkout the code on my computer. |
needs-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I will wait a bit more for Chris to review this.
If there is a big delay, we can have this merged.
There is no rush, as there is no relesed planed anytime soon...
but we might want do to a new release soon :)
I think that the comments from Chris were address. Thanks for your help! |
Before this commit, all the news fragments needed to be committed into git, or the fragments removal after building the news file would crash.
In my workflow, I add missing fragments before building the news file because I'm extracting author names from the git log, and towncrier crashes at the end of the build process.