RequestTraversalAgent: Pass reactor to Site #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 98.86% 98.86% +<.01%
==========================================
Files 26 26
Lines 2281 2282 +1
Branches 164 164
==========================================
+ Hits 2255 2256 +1
Misses 14 14
Partials 12 12
Continue to review full report at Codecov.
|
|
Looks unambiguously correct to me. Thanks! |
twm
added a commit
to twm/yarrharr
that referenced
this pull request
Jul 9, 2018
This prevents a real reactor from being initialized in the Django test runner. I'm hiding this behind an environment variable for now because of a treq issue; see twisted/treq#225
twm
added a commit
to twm/yarrharr
that referenced
this pull request
Jul 9, 2018
Pull in twisted/treq#225. Leave the poison reactor disabled due to twisted/treq#226.
twm
added a commit
to twm/treq
that referenced
this pull request
Mar 15, 2020
bmwiedemann
referenced
this pull request
in bmwiedemann/openSUSE
Mar 25, 2020
https://build.opensuse.org/request/show/788271 by user scarabeus_iv + dimstar_suse - version update to 20.3.0 - Python 3.7 support. (`#228 <https://github.com/twisted/treq/issues/228>`__) - `treq.testing.RequestTraversalAgent` now passes its memory reactor to the `twisted.web.server.Site` it creates, preventing the ``Site`` from polluting the global reactor. (`#225 <https://github.com/twisted/treq/issues/225>`__) - `treq.testing` no longer generates deprecation warnings about ``twisted.test.proto_helpers.MemoryReactor``. (`#253 <https://github.com/twisted/treq/issues/253>`__) - The ``download_file.py`` example has been updated to do a streaming download with *unbuffered=True*. (`#233 <https://github.com/twisted/treq/issues/233>`__) - The *agent* parameter to `treq.request()` has been documented. (`#235 <https://github.com/twisted/treq/issues/235>`__) - The typ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestTraversalAgent constructed a MemoryReactor for I/O, but didn't pass it to the Site it constructs, so the Site would create delayed calls in the global reactor. This pull request changes the MemoryReactor to a MemoryReactorClock and passes it to the Site.
See also twisted/twisted#1037 which clarifies the purpose of the HTTPFactory (Site superclass)
reactorargument.