Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode URL (IDN) support doesn't mix with params #264

Closed
twm opened this issue Jan 27, 2020 · 0 comments · Fixed by #265
Closed

Unicode URL (IDN) support doesn't mix with params #264

twm opened this issue Jan 27, 2020 · 0 comments · Fixed by #265
Assignees
@twm
Labels
bug

Comments

@twm
Copy link
Contributor

twm commented Jan 27, 2020

HTTPClient merges the params argument before coercing the URL to ASCII, so it bails with a UnicodeEncodeError when given a unicode url and any params.
@twm twm added the bug label Jan 27, 2020
@twm twm self-assigned this Jan 27, 2020
twm added a commit that referenced this issue Jan 27, 2020
@twm
Test for #264
625174a
@twm twm mentioned this issue Jan 27, 2020
Merged
@twm twm closed this as completed in #265 Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twm twm

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow mixing IDN and params twisted/treq
1 participant
@twm