Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 encode basic auth username/password #268

Closed
wants to merge 4 commits into from

Conversation

Copy link
Contributor

@twm twm left a comment

Hi @graingert, thank you for this! However I don't think it's complete enough to merge yet:

  1. Please add a test that verifies unicode text is encoded as UTF-8.
  2. Since this adds support for bytes username and password, please add a test of that too.
  3. Please update the documentation to reflect these changes. Specifically, mention the supported types in the docstring of treq.request() (in src/treq/api.py), and update the reference to RFC 2617 in the docs to RFC 7617.

Thanks again!

@twm
Copy link
Contributor

@twm twm commented Apr 18, 2020

Hi @graingert, gentle poke — do you plan to follow up here?

@graingert
Copy link
Member Author

@graingert graingert commented Apr 21, 2020

@twm sorry I don't have time to finish this

twm added a commit to twm/treq that referenced this issue Dec 26, 2020
Also accept bytes to allow user control over encoding.

Closes twisted#268.
twm added a commit to twm/treq that referenced this issue Dec 26, 2020
Also accept bytes to allow user control over encoding.

Closes twisted#268.
@twm twm mentioned this pull request Dec 26, 2020
@twm twm added the abandoned label Dec 26, 2020
@twm twm closed this in #315 Dec 28, 2020
@graingert
Copy link
Member Author

@graingert graingert commented Dec 28, 2020

thanks @twm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants