Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tmi endpoints #407

Merged
merged 1 commit into from
Apr 7, 2024
Merged

chore: remove tmi endpoints #407

merged 1 commit into from
Apr 7, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Apr 7, 2024

The TMI endpoints were shut down in April 2023. This removes the feature.


Aside:

  • I think we should aim for a release soon. The last release was almost seven months ago.
  • It might be nice if Client::req could use RPITIT, although it requires quite the MSRV bump from 1.65 to 1.75.
  • EventsubWebsocketData::Notification (and ::Revocation) should have some better type for payload like NotificationEvent, since the Payload's message can only be of one type at that point. It's not super visible in the example, but if you wanted to do something with the message, you'd need to match/if-let on it again.
  • We should consider if eventsub enums like Message should be marked non_exhaustive. Although it's nice for the library to be able to add variants and not break semver, it might be better for a user to get a compile error when updating and not handling an added variant (it's fine for enums like Event).

@Emilgardis
Copy link
Member

We have an issue for RPITIT

I agree with the payload enum being very annoying. If a way to improve it is possible we should aim to do that, should make an issue for it. Same goes for non_exhaustive on message

I want to do a real release, I'm only thinking about if #359 should be included or not.

@Emilgardis Emilgardis added this pull request to the merge queue Apr 7, 2024
Merged via the queue into main with commit 5618d7a Apr 7, 2024
16 checks passed
@Emilgardis Emilgardis deleted the chore/remove-tmi-endpoints branch April 7, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants