Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing ID field in Hype Train events #90

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

lleadbet
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Adds missing id field in all hype-train events, per #89 (ignore mistyped branch name).

Description of Changes:

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet requested review from a team, vpolouchkine and Jameka and removed request for a team August 13, 2021 14:57
@lleadbet lleadbet self-assigned this Aug 13, 2021
@lleadbet lleadbet linked an issue Aug 13, 2021 that may be closed by this pull request
Copy link

@Jameka Jameka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MonstersOnParade MonstersOnParade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@lleadbet lleadbet merged commit 151a5a4 into main Aug 13, 2021
@lleadbet lleadbet deleted the bugfix/fix-#83-missing-ID-field branch August 13, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event trigger hype-train-end does not include id field in event
3 participants