Support adding fields to nested Parquet structs #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parquet only calls converts for which it found the values. The missing values are not reported. The BlockBuilder must be appended with nulls for the missing values based on fieldIndex of the currently read value by Parquet.
…pass Ignore errors if the partitions have no corresponding valid hdfs path.
…gParquetColumns Append nulls for missing values in Parquet.
…d be reverted once prestodb#2863 is resolved.
Case insensitive types
This reverts commit 7365f1a. This blocked us from reading from mountable clusters.
Zookeeper based metastore
# Conflicts: # presto-main/src/main/java/com/facebook/presto/sql/analyzer/ExpressionAnalyzer.java
Run queries as user
Pick username from unix system and disallow overriding it.
added 24 commits
March 24, 2016 10:25
…_logging Use modules and query events for logging
…c_cleanup Move twitter classes to a twitter package
…mplete_events Add event processer and handlers and scribe query completion events
Upgrade to 0.143-tw-21
| @@ -69,6 +69,7 @@ | |||
| implements ConnectorSplitManager | |||
| { | |||
| public static final String PRESTO_OFFLINE = "presto_offline"; | |||
| private static final String STRUCT_PREFIX = "struct<"; | |||
There was a problem hiding this comment.
Is it possible to use "RowType" instead of "struct"? Or may be use com.facebook.presto.hive.HiveType.java.
Same for the rest of the patch. Presto has RowType and struct is not used here directly IIRC.
There was a problem hiding this comment.
Yeah, this part pained me pretty bad. I dug around for something more type safe but I missed HiveType. Refactoring.
|
LGTM, I saw some existing PR as well. We can start with this and wait for that to merge to master and released.. |
|
Yeah, sounds good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch of prestodb#4939 for twitter fork.