Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

fixed bug and added error handling when there are NAs in timestamp #51

Merged
merged 3 commits into from
Aug 31, 2015

Conversation

terrytangyuan
Copy link
Contributor

Currently, if there's NA in timestamp, R will give the following error:

Error in if (gran >= 86400) { : missing value where TRUE/FALSE needed

However, it is too hard for the user to know what the problem is, at least for me, I don't know where to fix the problem. I think this error handling is needed so that user knows where to go from here.

@terrytangyuan
Copy link
Contributor Author

See this issue #28 I didn't notice someone else had this issue. It took the users a while to figure out the problem. They'll have to dig into the code to see how to fix it.

@akejariwal
Copy link
Contributor

@caniszczyk I approve this PR. Please merge.

@terrytangyuan
Copy link
Contributor Author

Could you merge this as well? Thanks.

caniszczyk added a commit that referenced this pull request Aug 31, 2015
fixed bug and added error handling when there are NAs in timestamp
@caniszczyk caniszczyk merged commit 1f5deaa into twitter:master Aug 31, 2015
@terrytangyuan terrytangyuan deleted the bugfix branch August 31, 2015 20:12
@terrytangyuan
Copy link
Contributor Author

Thanks Chris.
On Aug 31, 2015 4:11 PM, "Chris Aniszczyk" notifications@github.com wrote:

Merged #51 #51.


Reply to this email directly or view it on GitHub
#51 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants